Enable Virtual Screen Coordinates

Enable Virtual Screen Coordinates and remove --ash-virtual-screen-coordinates
Update tests to work with VSC.

I'll land this after http://codereview.chromium.org/10795027/ is landed.

I kept active_root_window_ because we're planning to create a launcher per display, and I'm going to use it to decide on which display the status bubble will be shown.


BUG=123160
TEST=Updated tests, plus added new test cases to ExtendedDesktopText.ConvertPoint

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147977

[oshima, 2012-07-23 14:13:57]

On 2012/07/20 21:46:48, oshima wrote:

please hold. interactive_ui_tests failures looks real.

[oshima, 2012-07-23 20:10:53]

On 2012/07/23 14:13:57, oshima wrote:
> On 2012/07/20 21:46:48, oshima wrote:
> 
> please hold. interactive_ui_tests failures looks real.

Uploaded new patch. PTL.

[Daniel Erat, 2012-07-23 20:47:57]

lgtm

http://codereview.chromium.org/10790090/diff/7004/ash/display/display_control...
File ash/display/display_controller.cc (right):

http://codereview.chromium.org/10790090/diff/7004/ash/display/display_control...
ash/display/display_controller.cc:264: gfx::Screen::GetNumDisplays() <= 1) {
nit: you should be able to fit this on a single line

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
File ash/extended_desktop_unittest.cc (left):

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:469: // when the virtual screen coordinates is
implemented.a
nit: s/Cleanup/Clean up/, s/is/are/, remove trailing 'a'

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
File ash/extended_desktop_unittest.cc (right):

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:319: // the mouse is outside, so no move event
will be sent.
nit: capitalize "The"

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:479: // Convert point in the Root2's window to
the Root1's window Coord.
nit: remove the "the"s in this comment

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:487: // Convert point in the Root1's window to
the Root2's window Coord.
nit: ditto

http://codereview.chromium.org/10790090/diff/7004/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/10790090/diff/7004/ash/shell.h#newcode398
ash/shell.h:398: // Active root window. Never become NULL during the session.
nit: s/become/becomes/

[oshima, 2012-07-23 21:15:39]

http://codereview.chromium.org/10790090/diff/7004/ash/display/display_control...
File ash/display/display_controller.cc (right):

http://codereview.chromium.org/10790090/diff/7004/ash/display/display_control...
ash/display/display_controller.cc:264: gfx::Screen::GetNumDisplays() <= 1) {
On 2012/07/23 20:47:57, Daniel Erat wrote:
> nit: you should be able to fit this on a single line

Done.

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
File ash/extended_desktop_unittest.cc (right):

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:319: // the mouse is outside, so no move event
will be sent.
On 2012/07/23 20:47:57, Daniel Erat wrote:
> nit: capitalize "The"

Done.

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:479: // Convert point in the Root2's window to
the Root1's window Coord.
On 2012/07/23 20:47:57, Daniel Erat wrote:
> nit: remove the "the"s in this comment

Done.

http://codereview.chromium.org/10790090/diff/7004/ash/extended_desktop_unitte...
ash/extended_desktop_unittest.cc:487: // Convert point in the Root1's window to
the Root2's window Coord.
On 2012/07/23 20:47:57, Daniel Erat wrote:
> nit: ditto

Done.

http://codereview.chromium.org/10790090/diff/7004/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/10790090/diff/7004/ash/shell.h#newcode398
ash/shell.h:398: // Active root window. Never become NULL during the session.
On 2012/07/23 20:47:57, Daniel Erat wrote:
> nit: s/become/becomes/

Done.

[commit-bot: I haz the power, 2012-07-23 21:17:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10790090/13017

[commit-bot: I haz the power, 2012-07-23 22:47:14]

Try job failure for 10790090-13017 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...