Preferences support for multiple promos.

Preferences support for multiple promos.

* Add promo_type_. For now this is hardcoded to ntp_notification_promo, but we'll also allow bubble_promo soon.
* Store promo preferences in a dictionary, in a list, in a promo object. This reflects the structure of the promo as we receive it over the wire.
* Add ClearDeprecatedPrefs.
* Fix logic of CheckForNewNotification, HandleViewed and HandleClosed. These now call InitFromPreferences.
* Add better tests for HandleViewed and HandleClosed. Get rid of TestPrefs.

BUG=123061
TEST=unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148013

[achuithb, 2012-07-20 23:10:09]

Ruslan - please take a look.

[aruslan, 2012-07-23 18:50:52]

LGTM (I'm not a committer); I'll fix the Chrome for Android implementation and
upstream it once this is in.

[achuithb, 2012-07-23 18:52:57]

Rob, please take a look.

[Robert Sesek, 2012-07-23 20:38:49]

lgtm

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
File chrome/browser/web_resource/notification_promo.cc (right):

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:108: void
ClearDeprecatedPrefs(PrefService* prefs) {
Add a TODO for when to remove this.

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:372: base::DictionaryValue*
ntp_promo(new base::DictionaryValue);
nit: I think it's more common to write this as an assignment

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:397: base::ListValue*
promo_list(new base::ListValue);
nit: here too

[achuithb, 2012-07-23 23:12:02]

Addressed comments in patchset 9, along with rebase.

Thanks for the reviews, Rob and Ruslan!

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
File chrome/browser/web_resource/notification_promo.cc (right):

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:108: void
ClearDeprecatedPrefs(PrefService* prefs) {
On 2012/07/23 20:38:50, rsesek wrote:
> Add a TODO for when to remove this.

Done.

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:372: base::DictionaryValue*
ntp_promo(new base::DictionaryValue);
On 2012/07/23 20:38:50, rsesek wrote:
> nit: I think it's more common to write this as an assignment

Done.

http://codereview.chromium.org/10790089/diff/3004/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.cc:397: base::ListValue*
promo_list(new base::ListValue);
On 2012/07/23 20:38:50, rsesek wrote:
> nit: here too

Done.

[commit-bot: I haz the power, 2012-07-23 23:13:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10790089/16001

[commit-bot: I haz the power, 2012-07-24 00:42:21]

Change committed as 148013