Preferences support for multiple promos.

chrome/browser/web_resource/promo_resource_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <vector>
+
 #include "base/json/json_reader.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/web_resource/notification_promo.h"
@@ skipping 86 matching lines @@
     received_notification_ = false;
   }
 
   void InitPromoFromJson(bool should_receive_notification) {
     notification_promo_.InitFromJson(*test_json_);
     EXPECT_EQ(should_receive_notification,
               notification_promo_.new_notification());
 
     // Test the fields.
     TestNotification();
-    TestPrefs();
   }
 
   void TestNotification() {
     // Check values.
     EXPECT_EQ(notification_promo_.promo_text_, promo_text_);
 
 #if defined(OS_ANDROID)
     EXPECT_EQ(notification_promo_.promo_text_long_, promo_text_long_);
     EXPECT_EQ(notification_promo_.promo_action_type_, promo_action_type_);
     EXPECT_TRUE(notification_promo_.promo_action_args_.get() != NULL);
@@ skipping 22 matching lines @@
     // Check group within bounds.
     EXPECT_GE(notification_promo_.group_, 0);
     EXPECT_LT(notification_promo_.group_, num_groups_);
 
     // Views should be 0 for now.
     EXPECT_EQ(notification_promo_.views_, 0);
 
     EXPECT_EQ(notification_promo_.gplus_required_, gplus_required_);
   }
 
-  void TestPrefs() {
-    EXPECT_EQ(prefs_->GetString(prefs::kNtpPromoLine), promo_text_);
-#if defined(OS_ANDROID)
-    EXPECT_EQ(prefs_->GetString(prefs::kNtpPromoLineLong), promo_text_long_);
-    EXPECT_EQ(prefs_->GetString(prefs::kNtpPromoActionType),
-                                promo_action_type_);
-    const base::ListValue* lv = prefs_->GetList(prefs::kNtpPromoActionArgs);
-    EXPECT_TRUE(lv != NULL);
-    EXPECT_EQ(lv->GetSize(), promo_action_args_.size());
-    for (std::size_t i = 0; i < lv->GetSize(); ++i) {
-      std::string value;
-      EXPECT_TRUE(lv->GetString(i, &value));
-      EXPECT_EQ(value, promo_action_args_[i]);
-    }
-#endif  // defined(OS_ANDROID)
-
-    EXPECT_EQ(prefs_->GetDouble(prefs::kNtpPromoStart), start_);
-    EXPECT_EQ(prefs_->GetDouble(prefs::kNtpPromoEnd), end_);
-
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoNumGroups), num_groups_);
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoInitialSegment),
-                                 initial_segment_);
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoIncrement), increment_);
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoGroupTimeSlice), time_slice_);
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoGroupMax), max_group_);
-
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoViewsMax), max_views_);
-    EXPECT_EQ(prefs_->GetBoolean(prefs::kNtpPromoClosed), closed_);
-
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoGroup),
-              notification_promo_.group_);
-    EXPECT_EQ(prefs_->GetInteger(prefs::kNtpPromoViews), 0);
-
-    EXPECT_EQ(prefs_->GetBoolean(prefs::kNtpPromoGplusRequired),
-              gplus_required_);
-  }
-
   // Create a new NotificationPromo from prefs and compare to current
   // notification.
   void TestInitFromPrefs() {
     NotificationPromo prefs_notification_promo(profile_);
     prefs_notification_promo.InitFromPrefs();
 
     EXPECT_EQ(notification_promo_.prefs_,
               prefs_notification_promo.prefs_);
     EXPECT_EQ(notification_promo_.promo_text_,
               prefs_notification_promo.promo_text_);
@@ skipping 57 matching lines @@
       notification_promo_.group_ = i;
       EXPECT_TRUE(notification_promo_.CanShow());
     }
 
     // When max_group_ is 0, all groups pass.
     notification_promo_.max_group_ = 0;
     for (int i = 0; i < num_groups_; i += incr) {
       notification_promo_.group_ = i;
       EXPECT_TRUE(notification_promo_.CanShow());
     }
+    notification_promo_.WritePrefs();
   }
 
   void TestViews() {
+    notification_promo_.views_ = notification_promo_.max_views_ - 2;
+    notification_promo_.WritePrefs();
+
+    NotificationPromo new_promo(profile_);
+    new_promo.HandleViewed();
+    EXPECT_TRUE(new_promo.CanShow());
+    new_promo.HandleViewed();
+    EXPECT_FALSE(new_promo.CanShow());
+
+    notification_promo_.InitFromPrefs();
+    EXPECT_FALSE(notification_promo_.CanShow());
+
     // Test out of range views.
     for (int i = max_views_; i < max_views_ * 2; ++i) {
       notification_promo_.views_ = i;
       EXPECT_FALSE(notification_promo_.CanShow());
     }
 
     // Test in range views.
     for (int i = 0; i < max_views_; ++i) {
       notification_promo_.views_ = i;
       EXPECT_TRUE(notification_promo_.CanShow());
     }
+    notification_promo_.WritePrefs();
   }
 
   void TestClosed() {
+    NotificationPromo new_promo(profile_);
+    new_promo.InitFromPrefs();
+    EXPECT_TRUE(new_promo.CanShow());
+    new_promo.HandleClosed();
+    EXPECT_FALSE(new_promo.CanShow());
+    new_promo.InitFromPrefs();
+    EXPECT_FALSE(new_promo.CanShow());
+
     notification_promo_.closed_ = true;
     EXPECT_FALSE(notification_promo_.CanShow());
 
     notification_promo_.closed_ = false;
     EXPECT_TRUE(notification_promo_.CanShow());
+    notification_promo_.WritePrefs();
   }
 
   void TestPromoText() {
     notification_promo_.promo_text_.clear();
     EXPECT_FALSE(notification_promo_.CanShow());
 
     notification_promo_.promo_text_ = promo_text_;
     EXPECT_TRUE(notification_promo_.CanShow());
   }
 
@@ skipping 114 matching lines @@
   bool gplus_required_;
 };
 
 TEST_F(PromoResourceServiceTest, NotificationPromoTest) {
   // Check that prefs are set correctly.
   PrefService* prefs = profile_.GetPrefs();
   ASSERT_TRUE(prefs != NULL);
 
   NotificationPromoTest promo_test(&profile_);
 
-  // Make sure prefs are unset.
-  promo_test.TestPrefs();
-
   // Set up start and end dates and promo line in a Dictionary as if parsed
   // from the service.
 #if !defined(OS_ANDROID)
   promo_test.Init("{"
                   "  \"ntp_notification_promo\": ["
                   "    {"
                   "      \"date\":"
                   "        ["
                   "          {"
                   "            \"start\":\"15 Jan 2012 10:50:85 PST\","
@@ skipping 97 matching lines @@
   promo_test.TestIncrement();
   promo_test.TestGplus();
 }
 
 TEST_F(PromoResourceServiceTest, PromoServerURLTest) {
   GURL promo_server_url = NotificationPromo::PromoServerURL();
   EXPECT_FALSE(promo_server_url.is_empty());
   EXPECT_TRUE(promo_server_url.SchemeIs("https"));
   // TODO(achuith): Test this better.
 }