Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7598)

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.h

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some nits. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
index cd4809e4e5c433359d4804c751eff5eebb9f60c7..6fa5a7a9205640da8971a669d37b431001ee5300 100644
--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
@@ -8,6 +8,8 @@
#include <gtk/gtk.h>
#include "base/basictypes.h"
+#include "chrome/browser/ui/gtk/bubble/bubble_gtk.h"
+#include "chrome/common/password_generation_util.h"
#include "ui/base/gtk/gtk_signal.h"
#include "ui/gfx/rect.h"
#include "webkit/forms/password_form.h"
@@ -16,14 +18,13 @@ namespace autofill {
class PasswordGenerator;
}
-class BubbleGtk;
class TabContents;
// PasswordGenerationBubbleGtk is a bubble use to show possible generated
// passwords to users. It is set in page content, anchored at |anchor_rect|.
// If the generated password is accepted by the user, the renderer associated
// with |render_view_host| and the |password_manager| are informed.
-class PasswordGenerationBubbleGtk {
+class PasswordGenerationBubbleGtk : public BubbleDelegateGtk{
public:
PasswordGenerationBubbleGtk(const gfx::Rect& anchor_rect,
const webkit::forms::PasswordForm& form,
@@ -31,11 +32,15 @@ class PasswordGenerationBubbleGtk {
autofill::PasswordGenerator* password_generator);
virtual ~PasswordGenerationBubbleGtk();
+ // Overridden from BubbleDelegateGtk:
+ virtual void BubbleClosing(BubbleGtk* bubble, bool closed_by_escape) OVERRIDE;
+
private:
CHROMEGTK_CALLBACK_0(PasswordGenerationBubbleGtk, void, OnDestroy);
CHROMEGTK_CALLBACK_0(PasswordGenerationBubbleGtk, void, OnAcceptClicked);
CHROMEGTK_CALLBACK_2(PasswordGenerationBubbleGtk, void, OnRegenerateClicked,
GtkEntryIconPosition, GdkEvent*);
+ CHROMEGTK_CALLBACK_0(PasswordGenerationBubbleGtk, void, OnPasswordEdited);
CHROMEG_CALLBACK_0(
PasswordGenerationBubbleGtk, void, OnLearnMoreLinkClicked, GtkButton*);
@@ -53,6 +58,9 @@ class PasswordGenerationBubbleGtk {
// ownership of it.
autofill::PasswordGenerator* password_generator_;
+ // Store various status of the current living bubble.
+ password_generation::PasswordGenerationActions actions_;
+
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleGtk);
};

Powered by Google App Engine
This is Rietveld 408576698