Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some nits. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 7885d2196f61186cc4e0b259c66df86dbb61658c..3b34f71ce8015ea3f6caa241a1f689f0b3569882 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/autofill_messages.h"
+#include "chrome/common/password_generation_util.h"
#include "chrome/common/pref_names.h"
#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
@@ -239,6 +240,9 @@ void PasswordManager::OnPasswordFormsRendered(
// given consent, either through previously accepting the infobar or by having
// the browser generate the password.
provisional_save_manager_->SubmitPassed();
+ if (provisional_save_manager_->HasGeneratedPassword())
+ password_generation::LogPasswordGenerationEvents(
+ password_generation::SUBMITTED);
if (provisional_save_manager_->IsNewLogin() &&
!provisional_save_manager_->HasGeneratedPassword()) {
delegate_->AddSavePasswordInfoBarIfPermitted(
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/password_generation_bubble_gtk.h » ('j') | chrome/common/password_generation_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698