Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the test. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 7885d2196f61186cc4e0b259c66df86dbb61658c..550671d1391d3cd90f0de1862b81e9154723d134 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -4,12 +4,14 @@
#include "chrome/browser/password_manager/password_manager.h"
+#include "base/metrics/histogram.h"
#include "base/threading/platform_thread.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/password_manager/password_manager_delegate.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/password_generation_status.h"
#include "chrome/common/autofill_messages.h"
#include "chrome/common/pref_names.h"
#include "content/public/browser/user_metrics.h"
@@ -239,6 +241,10 @@ void PasswordManager::OnPasswordFormsRendered(
// given consent, either through previously accepting the infobar or by having
// the browser generate the password.
provisional_save_manager_->SubmitPassed();
+ if (provisional_save_manager_->HasGeneratedPassword())
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.EVENTS",
Ilya Sherman 2012/07/18 05:36:15 This histogram name does not match the name in oth
zysxqn 2012/07/18 19:16:46 Done.
+ password_generation::SUBMITTED,
+ password_generation::EVENT_ENUM_COUNT);
if (provisional_save_manager_->IsNewLogin() &&
!provisional_save_manager_->HasGeneratedPassword()) {
delegate_->AddSavePasswordInfoBarIfPermitted(

Powered by Google App Engine
This is Rietveld 408576698