Adding UMA stats.

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
+#include "base/metrics/histogram.h"
 #include "base/threading/platform_thread.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/password_generation_status.h"
 #include "chrome/common/autofill_messages.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "grit/generated_resources.h"
 
 using content::UserMetricsAction;
 using content::WebContents;
 using webkit::forms::PasswordForm;
@@ skipping 209 matching lines @@
     NOTREACHED();
     provisional_save_manager_.reset();
     return;
   }
 
   // Looks like a successful login attempt. Either show an infobar or
   // automatically save the login data. We prompt when the user hasn't already
   // given consent, either through previously accepting the infobar or by having
   // the browser generate the password.
   provisional_save_manager_->SubmitPassed();
+  if (provisional_save_manager_->HasGeneratedPassword())
+    UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.EVENTS",

[Ilya Sherman, 2012/07/18 05:36:15]

This histogram name does not match the name in other places, where you use
"PasswordGeneration.Events".  In general, the best way to avoid such errors is
to only have one UMA_HISTOGRAM_ENUMERATION call site for each histogram name --
often in a helper function -- and to call that helper function with the enum
value that you want to log from the various places where you want to log the
event.  That way, you get compile-time checking that the histogram is uniformly
named.

[zysxqn, 2012/07/18 19:16:46]

Done.

+                              password_generation::SUBMITTED,
+                              password_generation::EVENT_ENUM_COUNT);
   if (provisional_save_manager_->IsNewLogin() &&
       !provisional_save_manager_->HasGeneratedPassword()) {
     delegate_->AddSavePasswordInfoBarIfPermitted(
         provisional_save_manager_.release());
   } else {
     provisional_save_manager_->Save();
     provisional_save_manager_.reset();
   }
 }
 
@@ skipping 19 matching lines @@
       if (observer_) {
         observer_->OnAutofillDataAvailable(preferred_match.username_value,
                                            preferred_match.password_value);
       }
   }
 }
 
 bool PasswordManager::IsFillingEnabled() const {
   return delegate_->GetProfile() && *password_manager_enabled_;
 }