Debase our Uniscribe code. This moves FontUtils and all our Uniscribe code fr...

Debase our Uniscribe code. This moves FontUtils and all our Uniscribe code from
base/gfx to webkit/port/platform/graphics. I fixed the indenting and naming of
the moved code.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5561

[Erik does not do reviews, 2008-11-17 17:01:34]

Overall LGTM.  You might want to add someone who's a WebKit committer to the
reviewer list to check all of the WebKit style stuff, as I'm certainly not an
expert here.

http://codereview.chromium.org/10785/diff/246/259
File webkit/build/port/port.vcproj (right):

http://codereview.chromium.org/10785/diff/246/259#newcode718
Line 718:
RelativePath="..\..\port\platform\chromium\ClipboardUtilitiesChromium.cpp"
it looks like you need to sort the vcproj

http://codereview.chromium.org/10785/diff/246/252
File webkit/port/platform/graphics/UniscribeHelper_unittest.cpp (right):

http://codereview.chromium.org/10785/diff/246/252#newcode9
Line 9: #include "testing/gtest/include/gtest/gtest.h"
Do you think it will be an issue to land gtest dependencies? I know we've got
others already, but I'm just curious whether we need to come up with a different
plan here.

http://codereview.chromium.org/10785/diff/246/252#newcode142
Line 142: }  // namespace gfx
update comment

http://codereview.chromium.org/10785/diff/246/260
File webkit/tools/test_shell/test_shell_tests.vcproj (right):

http://codereview.chromium.org/10785/diff/246/260#newcode254
Line 254: RelativePath=".\test_shell_win.cc"
sort the vcproj

[brettw, 2008-11-17 17:26:49]

http://codereview.chromium.org/10785/diff/246/259
File webkit/build/port/port.vcproj (right):

http://codereview.chromium.org/10785/diff/246/259#newcode718
Line 718:
RelativePath="..\..\port\platform\chromium\ClipboardUtilitiesChromium.cpp"
On 2008/11/17 17:01:34, Erik Kay wrote:
> it looks like you need to sort the vcproj

Actually, this change made it sorted.

http://codereview.chromium.org/10785/diff/246/252
File webkit/port/platform/graphics/UniscribeHelper_unittest.cpp (right):

http://codereview.chromium.org/10785/diff/246/252#newcode9
Line 9: #include "testing/gtest/include/gtest/gtest.h"
I don't know about gtest. Eric Seidel has tried to get gtest upstream. I think
we'll just see how it goes.

http://codereview.chromium.org/10785/diff/246/260
File webkit/tools/test_shell/test_shell_tests.vcproj (right):

http://codereview.chromium.org/10785/diff/246/260#newcode254
Line 254: RelativePath=".\test_shell_win.cc"
On 2008/11/17 17:01:34, Erik Kay wrote:
> sort the vcproj

Again, this makes it sorted.