use Loadlibrary/GetProcAddress for XInput, rather than /DELAYLOAD

use Loadlibrary/GetProcAddress for XInput, rather than /DELAYLOAD

Win8 SDK xinput import lib pulls xinput1_4.dll, but we want to use 1_3, so load it manually.

R=cpu@chromium.org
BUG=113035
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148007

[cpu_(ooo_6.6-7.5), 2012-07-17 19:30:46]

lgtm

http://codereview.chromium.org/10781023/diff/1/content/browser/gamepad/platfo...
File content/browser/gamepad/platform_data_fetcher_win.cc (right):

http://codereview.chromium.org/10781023/diff/1/content/browser/gamepad/platfo...
content/browser/gamepad/platform_data_fetcher_win.cc:54:
xinput_dll_(FilePath(L"xinput1_3.dll")),
FILE_PATH_LITERAL("...")

[commit-bot: I haz the power, 2012-07-18 16:11:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/10781023/7001

[commit-bot: I haz the power, 2012-07-18 16:11:03]

Presubmit check for 10781023-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[scottmg, 2012-07-18 16:12:16]

+jam for owners

[jochen (gone - plz use gerrit), 2012-07-19 14:34:03]

drive-by content/ nits

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
File content/browser/gamepad/platform_data_fetcher_win.cc (right):

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.cc:53:
GamepadPlatformDataFetcherWin::GamepadPlatformDataFetcherWin() :
the : should go on the next line

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
File content/browser/gamepad/platform_data_fetcher_win.h (right):

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:17: #include
"base/scoped_native_library.h"
nit. alphabetical order

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:27: bool
devices_changed_hint) OVERRIDE;
virtual destructor missing

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:46: bool
GetXinputDllFunctions();
the style guide requires typedefs first, the functions, then data memebers

[scottmg, 2012-07-19 16:45:16]

thanks

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
File content/browser/gamepad/platform_data_fetcher_win.cc (right):

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.cc:53:
GamepadPlatformDataFetcherWin::GamepadPlatformDataFetcherWin() :
On 2012/07/19 14:34:04, jochen wrote:
> the : should go on the next line

Done.

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
File content/browser/gamepad/platform_data_fetcher_win.h (right):

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:17: #include
"base/scoped_native_library.h"
On 2012/07/19 14:34:04, jochen wrote:
> nit. alphabetical order

Done.

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:27: bool
devices_changed_hint) OVERRIDE;
On 2012/07/19 14:34:04, jochen wrote:
> virtual destructor missing

Done.

https://chromiumcodereview.appspot.com/10781023/diff/7001/content/browser/gam...
content/browser/gamepad/platform_data_fetcher_win.h:46: bool
GetXinputDllFunctions();
On 2012/07/19 14:34:04, jochen wrote:
> the style guide requires typedefs first, the functions, then data memebers

Done.

[jochen (gone - plz use gerrit), 2012-07-19 17:54:20]

content looks good

[jam, 2012-07-23 22:56:56]

lgtm

[commit-bot: I haz the power, 2012-07-23 22:58:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/10781023/13001

[commit-bot: I haz the power, 2012-07-24 00:38:18]

Change committed as 148007