Isolated FS for media devices.

webkit/fileapi/isolated_mount_point_provider.cc

Index: webkit/fileapi/isolated_mount_point_provider.cc
diff --git a/webkit/fileapi/isolated_mount_point_provider.cc b/webkit/fileapi/isolated_mount_point_provider.cc
index 35cbcf37e4eecf17250468d64bddaa685911b719..c550c7e96acf0db12020636ad19942afeef03d82 100644
--- a/webkit/fileapi/isolated_mount_point_provider.cc
+++ b/webkit/fileapi/isolated_mount_point_provider.cc
@@ -20,6 +20,8 @@
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/fileapi/isolated_file_util.h"
+#include "webkit/fileapi/media_file_system_operation.h"
+#include "webkit/fileapi/media_file_system_proxy_win.h"
 #include "webkit/fileapi/local_file_stream_writer.h"
 #include "webkit/fileapi/native_file_util.h"
 
@@ -109,6 +111,14 @@ FileSystemOperationInterface*
 IsolatedMountPointProvider::CreateFileSystemOperation(
     const FileSystemURL& url,
     FileSystemContext* context) const {
+  FilePath temp = GetPathFromURL(url);

[kinuko, 2012/07/18 10:33:24]

Please check if the path is not empty.  GetPathFromURL() may return an empty
path if the given URL is not valid.
(Or probably we should change GetPathFromURL() to return boolean value and let
it return the path by pointer)

+  printf("temp.path:%s\n", temp.value().c_str());

[kinuko, 2012/07/18 10:33:24]

Please remove this when you create a final patch

+  FilePath::StringType Filename(temp.value());

[kinuko, 2012/07/18 10:33:24]

nit: Filename -> filename

+  const wchar_t file_prefix[] = L"\\?\\";

[kinuko, 2012/07/18 10:33:24]

wchar_t -> FilePath::CharType

Since this works only for windows I don't have this code directly in this
provider.  Instead can we define a method like IsMediaFileSystem() which is
implemented in each MediaFileSystemProxy{Win,...} or somewhere you can put
platform-specific code?

+  int res = Filename.compare(0,4, file_prefix);
+  if (!res) {
+    return new fileapi::MediaFileSystemOperation(context, new fileapi::MediaFileSystemProxyWin(Filename));

[kinuko, 2012/07/18 10:33:24]

Ditto. We should have a platform-common factory method.

+  }
   return new FileSystemOperation(context);
 }