Isolated FS for media devices.

webkit/fileapi/isolated_mount_point_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/isolated_mount_point_provider.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/sequenced_task_runner.h"
 #include "webkit/blob/local_file_stream_reader.h"
 #include "webkit/fileapi/file_system_callback_dispatcher.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_file_stream_reader.h"
 #include "webkit/fileapi/file_system_operation.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/fileapi/isolated_file_util.h"
+#include "webkit/fileapi/media_file_system_operation.h"
+#include "webkit/fileapi/media_file_system_proxy_win.h"
 #include "webkit/fileapi/local_file_stream_writer.h"
 #include "webkit/fileapi/native_file_util.h"
 
 namespace fileapi {
 
 namespace {
 
 IsolatedContext* isolated_context() {
   return IsolatedContext::GetInstance();
 }
@@ skipping 69 matching lines @@
   FilePath path;
   if (!isolated_context()->CrackIsolatedPath(virtual_path, &fsid, NULL, &path))
     return FilePath();
   return path;
 }
 
 FileSystemOperationInterface*
 IsolatedMountPointProvider::CreateFileSystemOperation(
     const FileSystemURL& url,
     FileSystemContext* context) const {
+  FilePath temp = GetPathFromURL(url);

[kinuko, 2012/07/18 10:33:24]

Please check if the path is not empty.  GetPathFromURL() may return an empty
path if the given URL is not valid.
(Or probably we should change GetPathFromURL() to return boolean value and let
it return the path by pointer)

+  printf("temp.path:%s\n", temp.value().c_str());

[kinuko, 2012/07/18 10:33:24]

Please remove this when you create a final patch

+  FilePath::StringType Filename(temp.value());

[kinuko, 2012/07/18 10:33:24]

nit: Filename -> filename

+  const wchar_t file_prefix[] = L"\\?\\";

[kinuko, 2012/07/18 10:33:24]

wchar_t -> FilePath::CharType

Since this works only for windows I don't have this code directly in this
provider.  Instead can we define a method like IsMediaFileSystem() which is
implemented in each MediaFileSystemProxy{Win,...} or somewhere you can put
platform-specific code?

+  int res = Filename.compare(0,4, file_prefix);
+  if (!res) {
+    return new fileapi::MediaFileSystemOperation(context, new fileapi::MediaFileSystemProxyWin(Filename));

[kinuko, 2012/07/18 10:33:24]

Ditto. We should have a platform-common factory method.

+  }
   return new FileSystemOperation(context);
 }
 
 webkit_blob::FileStreamReader*
 IsolatedMountPointProvider::CreateFileStreamReader(
     const FileSystemURL& url,
     int64 offset,
     FileSystemContext* context) const {
   FilePath path = GetPathFromURL(url);
   return path.empty() ? NULL : new webkit_blob::LocalFileStreamReader(
       context->file_task_runner(), path, offset, base::Time());
 }
 
 FileStreamWriter* IsolatedMountPointProvider::CreateFileStreamWriter(
     const FileSystemURL& url,
     int64 offset,
     FileSystemContext* context) const {
   FilePath path = GetPathFromURL(url);
   return path.empty() ? NULL : new LocalFileStreamWriter(path, offset);
 }
 
 FileSystemQuotaUtil* IsolatedMountPointProvider::GetQuotaUtil() {
   // No quota support.
   return NULL;
 }
 
 }  // namespace fileapi