Introduces ImageSkia::GetRepresentations() for Mac

More and more places are using ImageSkiaSource.
Added ImageSkia::GetRepresentations() which attempts to get image representations for all of the supported scale factors.
Fixed mac code to use GetRepresentations instead of image_reps() as it is only a matter of time till we use enough ImageSkiaSources that we break hidpi mac code.

Bug=None
Test=
   ImageSkiaTest.GetRepresentationMultipleRepsPerScaleFactor 
     passes

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147615

[pkotwicz, 2012-07-15 01:47:46]

This fixes bugs which are bound to happen and did happen with the theme patch I
will be uploading later today.
I fixed the mac code to use GetRepresentations() instead of image_reps() because
it was only a matter of time till we used enough ImageSkiaSources that we broke
hidpi mac.
I made GetSupportedScaleFactors cross platform (not mac only). I need it to be
cross platform for theme code.

[oshima, 2012-07-16 17:07:37]

can you describe the issue in the description?

[pkotwicz, 2012-07-16 17:45:27]

Updated description as requested

[oshima, 2012-07-16 18:23:23]

On 2012/07/16 17:45:27, pkotwicz wrote:
> Updated description as requested

If GetRepresentations is needed only on mac, can you make it mac specific? Once
it made public API, it's easy to spread and I really want to avoid this "all
resources pattern" as much as possible.

[pkotwicz, 2012-07-17 03:22:46]

Ok, we can make GetRepresentations Mac specific for now. Shall we name
GetRepresentaitons something else in order to discourage use?

[sadrul, 2012-07-17 03:30:08]

Drive-by

http://codereview.chromium.org/10780010/diff/2017/chrome/browser/ui/views/wre...
File chrome/browser/ui/views/wrench_menu.cc (right):

http://codereview.chromium.org/10780010/diff/2017/chrome/browser/ui/views/wre...
chrome/browser/ui/views/wrench_menu.cc:554: new
gfx::ImageSkia(tinted_fullscreen_image_));
I think this is leaking ... you could just send &tinted_fullscreen_image_?

[pkotwicz, 2012-07-17 15:31:47]

Made ImageSkia::GetRepresentations() Mac only as requested.

[oshima, 2012-07-17 16:43:21]

lgtm with nits

http://codereview.chromium.org/10780010/diff/6034/ui/gfx/image/image_skia.cc
File ui/gfx/image/image_skia.cc (right):

http://codereview.chromium.org/10780010/diff/6034/ui/gfx/image/image_skia.cc#...
ui/gfx/image/image_skia.cc:235: }
nuke {}

http://codereview.chromium.org/10780010/diff/6034/ui/gfx/image/image_skia_uni...
File ui/gfx/image/image_skia_unittest.cc (right):

http://codereview.chromium.org/10780010/diff/6034/ui/gfx/image/image_skia_uni...
ui/gfx/image/image_skia_unittest.cc:60: ~NullSource() {
virtual

http://codereview.chromium.org/10780010/diff/6034/ui/gfx/image/image_skia_uni...
ui/gfx/image/image_skia_unittest.cc:144: gfx::Size(kSmallIcon1x, kSmallIcon1x));
will this fit single line?

[pkotwicz, 2012-07-17 17:38:13]

Sky for OWNERS

[sky, 2012-07-17 22:00:49]

LGTM

[commit-bot: I haz the power, 2012-07-20 02:16:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10780010/15001

[commit-bot: I haz the power, 2012-07-20 04:34:01]

Change committed as 147615