Issue 10779013: Simplify head emission a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10779013: Simplify head emission a bit. (Closed)

Created:
8 years, 5 months ago by Anton Muhin

Modified:
8 years, 5 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify head emission a bit. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=9666

Patch Set 1 #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	lib/dom/scripts/systemnative.py	View		2 chunks	+12 lines, -12 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (left): http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.py#oldcode805 lib/dom/scripts/systemnative.py:805: '$HEAD\n', Is it ok to change the order? ...

8 years, 5 months ago (2012-07-16 15:43:16 UTC) #2

Anton Muhin

8 years, 5 months ago (2012-07-16 15:46:45 UTC) #3

http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.py
File lib/dom/scripts/systemnative.py (left):

http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.p...
lib/dom/scripts/systemnative.py:805: '$HEAD\n',
On 2012/07/16 15:43:16, podivilov wrote:
> Is it ok to change the order?

That should be, but let me lift it up to keep the former semantics.

http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.py
File lib/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/10779013/diff/1/lib/dom/scripts/systemnative.p...
lib/dom/scripts/systemnative.py:801: head_emitter.Emit(
On 2012/07/16 15:43:16, podivilov wrote:
> Maybe just emit(runtime_check)?

Missing trailing \n, let's keep it as is for now.

Expand Messages | Collapse Messages