Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ui/panels/panel_cocoa.mm

Issue 10777004: Support chrome.windows extension API events for browserless Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_cocoa.mm b/chrome/browser/ui/panels/panel_cocoa.mm
index 6d64a4525114f17c103a54886a2e91f1e13be3c2..c323db6474f8ed3bb2a48909c4640b6fe950fdd2 100644
--- a/chrome/browser/ui/panels/panel_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_cocoa.mm
@@ -51,6 +51,12 @@ bool PanelCocoa::isClosed() {
void PanelCocoa::ShowPanel() {
ShowPanelInactive();
ActivatePanel();
+
+ // |-makeKeyAndOrderFront:| won't send |-windowDidBecomeKey:| until we
+ // return to the runloop. This causes extension tests that wait for the
+ // active status change notification to fail, so we send an active status
+ // notification here.
+ panel_->OnActiveStateChanged(true);
Dmitry Titov 2012/07/13 18:24:17 oy. Can it be that the consumers of that call are
jennb 2012/07/13 18:47:48 I had the same concerns, therefore I added the EXP
}
void PanelCocoa::ShowPanelInactive() {

Powered by Google App Engine
This is Rietveld 408576698