Support chrome.windows extension API events for browserless Panels.

chrome/browser/ui/panels/panel_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_cocoa.h"
 
 #include "base/logging.h"
 #import "chrome/browser/ui/cocoa/chrome_event_processing_window.h"
 #include "chrome/browser/ui/panels/panel.h"
 #import "chrome/browser/ui/panels/panel_titlebar_view_cocoa.h"
@@ skipping 33 matching lines @@
 PanelCocoa::~PanelCocoa() {
 }
 
 bool PanelCocoa::isClosed() {
   return !controller_;
 }
 
 void PanelCocoa::ShowPanel() {
   ShowPanelInactive();
   ActivatePanel();
+
+  // |-makeKeyAndOrderFront:| won't send |-windowDidBecomeKey:| until we
+  // return to the runloop. This causes extension tests that wait for the
+  // active status change notification to fail, so we send an active status
+  // notification here.
+  panel_->OnActiveStateChanged(true);

[Dmitry Titov, 2012/07/13 18:24:17]

oy. 
Can it be that the consumers of that call are/will assume that the window
already changed the status when it is called? If so, they can be broken.

Or, what if ActivatePanel actually starts to fail to activate a panel, but the
tests will succeed because we call OnActiveStateChanged directly here?

[jennb, 2012/07/13 18:47:48]

I had the same concerns, therefore I added the EXPECT_EQ in
test_panel_active_state_observer.cc to see if the state is actually changed even
though |-windowDidBecomeKey| has not been fired. All was happy.

 }
 
 void PanelCocoa::ShowPanelInactive() {
   if (isClosed())
     return;
 
   // This method may be called several times, meaning 'ensure it's shown'.
   // Animations don't look good when repeated - hence this flag is needed.
   if (is_shown_) {
     return;
@@ skipping 309 matching lines @@
       return ![[titlebar() closeButton] isHidden];
     case panel::MINIMIZE_BUTTON:
       return ![[titlebar() minimizeButton] isHidden];
     case panel::RESTORE_BUTTON:
       return ![[titlebar() restoreButton] isHidden];
     default:
       NOTREACHED();
   }
   return false;
 }