Issue 1077009: Fixed pyautolib build for chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077009: Fixed pyautolib build for chromeos (Closed)

Created:
10 years, 9 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
Sean Parent

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed pyautolib build for chromeos BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42281

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sean Parent

Are you sure this is the best fix? I haven't looked at the offending code ...

10 years, 9 months ago (2010-03-22 22:48:06 UTC) #2

zel

10 years, 9 months ago (2010-03-22 23:00:47 UTC) #3

This code is autogenerated by SWIG, we might want to fix that lib later but
for now we can live with this.

On Mon, Mar 22, 2010 at 3:48 PM, <seanparent@chromium.org> wrote:

> Are you sure this is the best fix? I haven't looked at the offending code
> but
> using an uninitialized variable seems worth addressing. Otherwise -
>
> LGTM
>
>
> http://codereview.chromium.org/1077009
>

Expand Messages | Collapse Messages