chrome/browser/browser_window.h - Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_window.h

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_window.h

===================================================================

--- chrome/browser/browser_window.h (revision 5492)

+++ chrome/browser/browser_window.h (working copy)

@@ -71,11 +71,10 @@

// TODO(beng): make this pure virtual after XPFrame/VistaFrame retire.

virtual void UpdateTitleBar() = 0;

- // Updates internal state specifying whether the throbber is to be shown.

- // If the throbber was shown, and should still be shown, the frame of the

- // throbber is advanced.

- // If necessary, the appropriate painting is scheduled.

- virtual void ValidateThrobber() { }

+ // Update any loading animations running in the window. |loading| is true if

sky 2008/11/14 22:07:21 nit: loading -> should_animate

+ // there are tabs loading and the animations should continue, false if there

+ // are no active loads and the animations should end.

+ virtual void UpdateLoadingAnimations(bool should_animate) = 0;

// TODO(beng): RENAME (GetRestoredBounds)

// Returns the nonmaximized bounds of the frame (even if the frame is

« chrome/browser/browser.cc ('K') | « chrome/browser/browser.cc ('k') | chrome/browser/tabs/tab_strip_model.h » ('j') | chrome/browser/views/frame/browser_view.cc » ('J')