chrome/browser/first_run/first_run_internal.h - Issue 10756023: Fix the first_run regression issue related to skip_first_run_ui setting processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run_internal.h

Issue 10756023: Fix the first_run regression issue related to skip_first_run_ui setting processing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/first_run/first_run_internal.h

diff --git a/chrome/browser/first_run/first_run_internal.h b/chrome/browser/first_run/first_run_internal.h

index 610a516f2a8702b8da8c3abd6d668852a2db2bef..5cebc77a585f8526fdcb0f2483a493478311b8da 100644

--- a/chrome/browser/first_run/first_run_internal.h

+++ b/chrome/browser/first_run/first_run_internal.h

@@ -63,8 +63,10 @@ void SetShowWelcomePagePrefIfNeeded(

void SetDefaultBrowser(installer::MasterPreferences* install_prefs);

-// Returns true if the first-run-ui process should be skipped.

-bool SkipFirstRunUI(installer::MasterPreferences* install_prefs);

+// Returns true if first run ui should not be skipped, which are the cases that

+// either skip_first_run_ui setting is set to false, or the setting is not

+// found or specified.

+bool NotSkipFirstRunUI(installer::MasterPreferences* install_prefs);

msw 2012/07/10 01:51:21 Restore the original name and comment.

jennyz 2012/07/10 16:07:16 Done.

// Sets ping_delay.

void SetRLZPref(first_run::MasterPrefs* out_prefs,

« chrome/browser/first_run/first_run.cc ('K') | « chrome/browser/first_run/first_run.cc ('k') | chrome/browser/first_run/first_run_posix.cc » ('j') | no next file with comments »