Fix the first_run regression issue related to skip_first_run_ui setting processing.

chrome/browser/first_run/first_run.cc

Index: chrome/browser/first_run/first_run.cc
diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc
index dd04fde3476550f7dd8851b618c0583216609974..4ad8574d16e66491e71674a2a1d968aa3fe65433 100644
--- a/chrome/browser/first_run/first_run.cc
+++ b/chrome/browser/first_run/first_run.cc
@@ -266,15 +266,15 @@ void SetShowWelcomePagePrefIfNeeded(
   }
 }
 
-bool SkipFirstRunUI(installer::MasterPreferences* install_prefs) {
+bool NotSkipFirstRunUI(installer::MasterPreferences* install_prefs) {

[msw, 2012/07/10 01:51:21]

I dislike this name, please leave it SkipFirstRunUI.

[jennyz, 2012/07/10 16:07:16]

Done.

   // TODO(mirandac): Refactor skip-first-run-ui process into regular first run
   // import process.  http://crbug.com/49647
   // Note we are skipping all other master preferences if skip-first-run-ui

[msw, 2012/07/10 01:51:21]

This note/comment belong with the code that actually returns early if the value
isn't specified. Or, (if you prefer) you can make a utility function here like
"bool HasMasterPrefs()" that just returns whether or not this bool is specified
(presuming that we still intend to enforce the behavior described here), and put
the comment there.

[jennyz, 2012/07/10 16:07:16]

Done.

   // is *not* specified. (That is, we continue only if skipping first run ui.)
   bool value = false;
-  return (install_prefs->GetBool(
-          installer::master_preferences::kDistroSkipFirstRunPref,
-          &value) || !value);
+  return (!install_prefs->GetBool(

[msw, 2012/07/10 01:51:21]

In keeping the original name, this function can just do:
bool value = false;             (returns false by default)
install_prefs->GetBool(...);    (ignore the read success/fail)
return value;

[jennyz, 2012/07/10 16:07:16]

Done.

+             installer::master_preferences::kDistroSkipFirstRunPref, &value)
+          || !value);
 }
 
 void SetRLZPref(first_run::MasterPrefs* out_prefs,