Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10752007: Mocking library improvements: (Closed)

Created:
8 years, 5 months ago by gram
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mocking library improvements: - Timestamped logs - Using enum pattern - Improved verifiers This is basically the same as the last reverted change but has a few bug fixes and now uses the enum pattern. Committed: https://code.google.com/p/dart/source/detail?r=9489

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -202 lines) Patch
lib/unittest/mock.dart View 1 2 3 20 chunks +368 lines, -167 lines 0 comments Download
lib/unittest/operator_matchers.dart View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
tests/lib/unittest/unittest_test.dart View 1 2 3 7 chunks +54 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
8 years, 5 months ago (2012-07-09 21:15:23 UTC) #1
Siggi Cherem (dart-lang)
http://codereview.chromium.org/10752007/diff/1/lib/unittest/mock.dart File lib/unittest/mock.dart (right): http://codereview.chromium.org/10752007/diff/1/lib/unittest/mock.dart#newcode253 lib/unittest/mock.dart:253: Date when; when => time? (otherwise it is confusing ...
8 years, 5 months ago (2012-07-09 22:11:05 UTC) #2
gram
PTAL https://chromiumcodereview.appspot.com/10752007/diff/1/lib/unittest/mock.dart File lib/unittest/mock.dart (right): https://chromiumcodereview.appspot.com/10752007/diff/1/lib/unittest/mock.dart#newcode253 lib/unittest/mock.dart:253: Date when; On 2012/07/09 22:11:05, sigmund wrote: > ...
8 years, 5 months ago (2012-07-09 22:35:29 UTC) #3
Siggi Cherem (dart-lang)
8 years, 5 months ago (2012-07-09 22:38:25 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698