Issue 1075014: Linux: Fix some GdkPixbuf leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1075014: Linux: Fix some GdkPixbuf leaks. (Closed)

Created:
10 years, 9 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
tony, Alexander Potapenko, Charlie Lee, rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Linux: Fix some GdkPixbuf leaks. Also expand some documentation for functions that returned a GdkPixbuf about who owns the reference BUG=38895 TEST=manual test that nothing is broken, will watch bot for leak results Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42302

Patch Set 1 #

Patch Set 2 : move BrowserThemeProvider comment to the public functions #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_install_prompt_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_installed_bubble_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/hung_renderer_dialog_gtk.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/keyword_editor_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gfx/gtk_util.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/heapcheck/suppressions.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	views/controls/menu/native_menu_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 9 months ago (2010-03-23 07:14:49 UTC) #4

On 2010/03/22 23:24:17, mattm wrote:
> 

LGTM
Thanks for doing this!

Expand Messages | Collapse Messages