views/controls/menu/native_menu_gtk.cc - Issue 1075014: Linux: Fix some GdkPixbuf leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/menu/native_menu_gtk.cc

Issue 1075014: Linux: Fix some GdkPixbuf leaks. (Closed)

Patch Set: move BrowserThemeProvider comment to the public functions Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/menu/native_menu_gtk.cc

diff --git a/views/controls/menu/native_menu_gtk.cc b/views/controls/menu/native_menu_gtk.cc

index 395e9a5f182e6f2e1342cb73dcebc10fe5a50846..f551ed6d9fc52cdc12162da626c18e31e282ceac 100644

--- a/views/controls/menu/native_menu_gtk.cc

+++ b/views/controls/menu/native_menu_gtk.cc

@@ -224,6 +224,7 @@ GtkWidget* NativeMenuGtk::AddMenuItemAt(int index,

GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(&icon);

gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(menu_item),

gtk_image_new_from_pixbuf(pixbuf));

+ g_object_unref(pixbuf);

} else {

menu_item = gtk_menu_item_new_with_mnemonic(label.c_str());

}

« no previous file with comments | « tools/heapcheck/suppressions.txt ('k') | no next file » | no next file with comments »