Eliminate all UI thread decoding of extension images....

chrome/common/extensions/extension.h

Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h	(revision 42362)
+++ chrome/common/extensions/extension.h	(working copy)
@@ -185,14 +185,20 @@
   static bool IsPrivilegeIncrease(Extension* old_extension,
                                   Extension* new_extension);
 
+  // *** HITS THE FILESYSTEM. Do not call on UI thread! ***
   // Given an extension and icon size, read it if present and decode it into
   // result.
+  // NOTE: If you need the icon on the UI thread, please use the
+  // ImageLoadingTracker, which uses the File thread to decode.

[Aaron Boodman, 2010/03/23 19:10:55]

Do we still have callers for these?

[Finnur, 2010/03/23 21:19:48]

There are a few callers out there, all on the file thread. There is a mac class
calling it that I suspect can be replaced wholesale using this new scheme, but
that's better for a mac person to decide, implement and test.

On 2010/03/23 19:10:55, Aaron Boodman wrote:

   static void DecodeIcon(Extension* extension,
                          Icons icon_size,
                          scoped_ptr<SkBitmap>* result);
 
+  // *** HITS THE FILESYSTEM. Do not call on UI thread! ***
   // Given an icon_path and icon size, read it if present and decode it into
   // result.
+  // NOTE: If you need the icon on the UI thread, please use the
+  // ImageLoadingTracker, which uses the File thread to decode.
   static void DecodeIconFromPath(const FilePath& icon_path,
                                  Icons icon_size,
                                  scoped_ptr<SkBitmap>* result);