Eliminate all UI thread decoding of extension images....

chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Index: chrome/browser/gtk/browser_actions_toolbar_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_actions_toolbar_gtk.cc	(revision 42362)
+++ chrome/browser/gtk/browser_actions_toolbar_gtk.cc	(working copy)
@@ -69,7 +69,7 @@
                       Extension* extension)
       : toolbar_(toolbar),
         extension_(extension),
-        tracker_(NULL),
+        tracker_(this),

[Aaron Boodman, 2010/03/23 19:10:55]

allow_this_in_initalizer ?

[Finnur, 2010/03/23 21:19:48]

The ALLOW_THIS macro is for working around a VC compiler warning and compiles to
nothing in other compilers. Given that this is a gtk specific class, I think we
don't need it.

         tab_specific_icon_(NULL),
         default_icon_(NULL) {
     button_.Own(
@@ -85,8 +85,7 @@
     // changed at runtime, so we can load this now and cache it.
     std::string path = extension_->browser_action()->default_icon_path();
     if (!path.empty()) {
-      tracker_ = new ImageLoadingTracker(this, 1);
-      tracker_->PostLoadImageTask(extension_->GetResource(path),
+      tracker_.PostLoadImageTask(extension_->GetResource(path),
           gfx::Size(Extension::kBrowserActionIconMaxSize,
                     Extension::kBrowserActionIconMaxSize));
     }
@@ -112,9 +111,6 @@
       g_object_unref(default_icon_);
 
     button_.Destroy();
-
-    if (tracker_)
-      tracker_->StopTrackingImageLoad();
   }
 
   GtkWidget* widget() { return button_.get(); }
@@ -132,12 +128,11 @@
   }
 
   // ImageLoadingTracker::Observer implementation.
-  void OnImageLoaded(SkBitmap* image, size_t index) {
+  void OnImageLoaded(SkBitmap* image, int index) {
     if (image) {
       default_skbitmap_ = *image;
       default_icon_ = gfx::GdkPixbufFromSkBitmap(image);
     }
-    tracker_ = NULL;  // The tracker object will delete itself when we return.
     UpdateState();
   }
 
@@ -264,7 +259,7 @@
   OwnedWidgetGtk button_;
 
   // Loads the button's icons for us on the file thread.
-  ImageLoadingTracker* tracker_;
+  ImageLoadingTracker tracker_;
 
   // If we are displaying a tab-specific icon, it will be here.
   GdkPixbuf* tab_specific_icon_;
@@ -633,8 +628,8 @@
   return TRUE;
 }
 
-void BrowserActionsToolbarGtk::OnHierarchyChanged(GtkWidget* widget,
-                                                  GtkWidget* previous_toplevel) {
+void BrowserActionsToolbarGtk::OnHierarchyChanged(
+    GtkWidget* widget, GtkWidget* previous_toplevel) {
   GtkWidget* toplevel = gtk_widget_get_toplevel(widget);
   if (!GTK_WIDGET_TOPLEVEL(toplevel))
     return;