Extensions Docs Server: Intro data source

chrome/common/extensions/docs/server2/template_data_source_test.py

Index: chrome/common/extensions/docs/server2/template_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/template_data_source_test.py b/chrome/common/extensions/docs/server2/template_data_source_test.py
index a1511504629bc0feba8e45188a4baee1f70067cf..36736dde175876a8bd936aa38b4c377411c9c241 100755
--- a/chrome/common/extensions/docs/server2/template_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/template_data_source_test.py
@@ -16,6 +16,7 @@ class TemplateDataSourceTest(unittest.TestCase):
   def setUp(self):
     self._base_path = os.path.join('test_data', 'template_data_source')
     self._fake_api_data_source = {}
+    self._fake_intro_data_source = {}
 
   def _ReadLocalFile(self, filename):
     with open(os.path.join(self._base_path, filename), 'r') as f:
@@ -34,6 +35,7 @@ class TemplateDataSourceTest(unittest.TestCase):
     cache_builder = FetcherCache.Builder(fetcher, 0)
     t_data_source = TemplateDataSource('fake_branch',
                                        self._fake_api_data_source,
+                                       self._fake_intro_data_source,
                                        cache_builder,
                                        ['./'])
     template_a1 = Handlebar(self._ReadLocalFile('test1.html'))
@@ -52,6 +54,7 @@ class TemplateDataSourceTest(unittest.TestCase):
     cache_builder = FetcherCache.Builder(fetcher, 0)
     t_data_source = TemplateDataSource('fake_branch',
                                        self._fake_api_data_source,
+                                       self._fake_intro_data_source,
                                        cache_builder,
                                        ['./'])
     self.assertEqual(self._ReadLocalFile('test_expected.html'),
@@ -67,12 +70,14 @@ class TemplateDataSourceTest(unittest.TestCase):
         'test1',
         TemplateDataSource('fake_branch',
                            json.loads(self._ReadLocalFile('test1.json')),

[not at google - send to devlin, 2012/07/10 01:00:20]

Can you pull these TemplateDataSource constructions into a factory method with
its only parameter the input dict? Would clean up this code a bit, there are 4
instances of very similar code.

[cduvall, 2012/07/10 01:13:14]

Done.

+                           self._fake_intro_data_source,
                            cache_builder,
                            ['./']))
     self._RenderTest(
         'test2',
         TemplateDataSource('fake_branch',
                            json.loads(self._ReadLocalFile('test2.json')),
+                           self._fake_intro_data_source,
                            cache_builder,
                            ['./']))