Extensions Docs Server: Intro data source

chrome/common/extensions/docs/server2/template_data_source_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 import unittest
 
 from fetcher_cache import FetcherCache
 from local_fetcher import LocalFetcher
 from template_data_source import TemplateDataSource
 from third_party.handlebar import Handlebar
 
 class TemplateDataSourceTest(unittest.TestCase):
   def setUp(self):
     self._base_path = os.path.join('test_data', 'template_data_source')
     self._fake_api_data_source = {}
+    self._fake_intro_data_source = {}
 
   def _ReadLocalFile(self, filename):
     with open(os.path.join(self._base_path, filename), 'r') as f:
       return f.read()
 
   def _RenderTest(self, name, data_source):
     template_name = name + '_tmpl.html'
     template = Handlebar(self._ReadLocalFile(template_name))
     self.assertEquals(
         self._ReadLocalFile(name + '_expected.html'),
         data_source.Render(template_name))
 
   def testSimple(self):
     self._base_path = os.path.join(self._base_path, 'simple')
     fetcher = LocalFetcher(self._base_path)
     cache_builder = FetcherCache.Builder(fetcher, 0)
     t_data_source = TemplateDataSource('fake_branch',
                                        self._fake_api_data_source,
+                                       self._fake_intro_data_source,
                                        cache_builder,
                                        ['./'])
     template_a1 = Handlebar(self._ReadLocalFile('test1.html'))
     self.assertEqual(template_a1.render({}, {'templates': {}}).text,
         t_data_source['test1'].render({}, {'templates': {}}).text)
 
     template_a2 = Handlebar(self._ReadLocalFile('test2.html'))
     self.assertEqual(template_a2.render({}, {'templates': {}}).text,
         t_data_source['test2'].render({}, {'templates': {}}).text)
 
     self.assertEqual(None, t_data_source['junk.html'])
 
   def testPartials(self):
     self._base_path = os.path.join(self._base_path, 'partials')
     fetcher = LocalFetcher(self._base_path)
     cache_builder = FetcherCache.Builder(fetcher, 0)
     t_data_source = TemplateDataSource('fake_branch',
                                        self._fake_api_data_source,
+                                       self._fake_intro_data_source,
                                        cache_builder,
                                        ['./'])
     self.assertEqual(self._ReadLocalFile('test_expected.html'),
         t_data_source['test_tmpl'].render(
             json.loads(self._ReadLocalFile('input.json')), t_data_source).text)
 
   def testRender(self):
     self._base_path = os.path.join(self._base_path, 'render')
     fetcher = LocalFetcher(self._base_path)
     context = json.loads(self._ReadLocalFile('test1.json'))
     cache_builder = FetcherCache.Builder(fetcher, 0)
     self._RenderTest(
         'test1',
         TemplateDataSource('fake_branch',
                            json.loads(self._ReadLocalFile('test1.json')),

[not at google - send to devlin, 2012/07/10 01:00:20]

Can you pull these TemplateDataSource constructions into a factory method with
its only parameter the input dict? Would clean up this code a bit, there are 4
instances of very similar code.

[cduvall, 2012/07/10 01:13:14]

Done.

+                           self._fake_intro_data_source,
                            cache_builder,
                            ['./']))
     self._RenderTest(
         'test2',
         TemplateDataSource('fake_branch',
                            json.loads(self._ReadLocalFile('test2.json')),
+                           self._fake_intro_data_source,
                            cache_builder,
                            ['./']))
 
 if __name__ == '__main__':
   unittest.main()