Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10735010: 3D Compositing in <browser>, first draft. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Major changes to clean up deadlock & other issues Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index fc80140e3606f467b22478eed8bb83b8b9c090e1..31264699646d457a5f2dc81685b9333f16ca96f9 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3060,11 +3060,16 @@ bool WebContentsImpl::CreateRenderViewForRenderManager(
int32 max_page_id =
GetMaxPageIDForSiteInstance(render_view_host->GetSiteInstance());
- std::string embedder_channel_name;
- int embedder_container_id;
- GetBrowserPluginEmbedderInfo(render_view_host,
- &embedder_channel_name,
- &embedder_container_id);
+ content::NotificationService::current()->Notify(
+ content::NOTIFICATION_WILL_CREATE_RENDER_VIEW,
+ content::Source<WebContents>(this),
+ content::Details<RenderViewHost>(render_view_host));
+
+ std::string embedder_channel_name;
+ int embedder_container_id;
+ GetBrowserPluginEmbedderInfo(render_view_host,
+ &embedder_channel_name,
+ &embedder_container_id);
scshunt 2012/08/12 01:42:45 The indentation is off, here. And this seems /real
scshunt 2012/08/17 17:30:28 In retrospect, I don't know what I was talking abo
if (!static_cast<RenderViewHostImpl*>(
render_view_host)->CreateRenderView(string16(),
opener_route_id,

Powered by Google App Engine
This is Rietveld 408576698