3D Compositing in <browser>, first draft.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 3042 matching lines @@
 
   // Now that the RenderView has been created, we need to tell it its size.
   if (rwh_view)
     rwh_view->SetSize(view_->GetContainerSize());
 
   // Make sure we use the correct starting page_id in the new RenderView.
   UpdateMaxPageIDIfNecessary(render_view_host);
   int32 max_page_id =
       GetMaxPageIDForSiteInstance(render_view_host->GetSiteInstance());
 
-  std::string embedder_channel_name;
-  int embedder_container_id;
-  GetBrowserPluginEmbedderInfo(render_view_host,
-                               &embedder_channel_name,
-                               &embedder_container_id);
+  content::NotificationService::current()->Notify(
+      content::NOTIFICATION_WILL_CREATE_RENDER_VIEW,
+      content::Source<WebContents>(this),
+      content::Details<RenderViewHost>(render_view_host));
+
+   std::string embedder_channel_name;
+   int embedder_container_id;
+   GetBrowserPluginEmbedderInfo(render_view_host,
+                                &embedder_channel_name,
+                                &embedder_container_id);

[scshunt, 2012/08/12 01:42:45]

The indentation is off, here. And this seems /really/ fragile, since the
ordering is important. A comment should be here at the very least, explaining
why the notification must go through first.

[scshunt, 2012/08/17 17:30:28]

In retrospect, I don't know what I was talking about.

   if (!static_cast<RenderViewHostImpl*>(
           render_view_host)->CreateRenderView(string16(),
                                               opener_route_id,
                                               max_page_id,
                                               embedder_channel_name,
                                               embedder_container_id)) {
     return false;
   }
 
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
@@ skipping 74 matching lines @@
       old_browser_plugin_host()->embedder_render_process_host();
   *embedder_container_id = old_browser_plugin_host()->instance_id();
   int embedder_process_id =
       embedder_render_process_host ? embedder_render_process_host->GetID() : -1;
   if (embedder_process_id != -1) {
     *embedder_channel_name =
         StringPrintf("%d.r%d", render_view_host->GetProcess()->GetID(),
                      embedder_process_id);
   }
 }