Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8042)

Unified Diff: chrome/renderer/autofill/password_generation_manager.cc

Issue 10705006: Focus should be moved to the next input field after we generate the password. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: A nit. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/password_generation_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/password_generation_manager.cc
diff --git a/chrome/renderer/autofill/password_generation_manager.cc b/chrome/renderer/autofill/password_generation_manager.cc
index ac937607972b59d44288add572cc93f4b96ad5e3..34cb027dd260d86b5c0a295dc110df6fe360dfcb 100644
--- a/chrome/renderer/autofill/password_generation_manager.cc
+++ b/chrome/renderer/autofill/password_generation_manager.cc
@@ -56,8 +56,9 @@ bool GetAccountCreationPasswordFields(
PasswordGenerationManager::PasswordGenerationManager(
content::RenderView* render_view)
: content::RenderViewObserver(render_view),
+ render_view_(render_view),
enabled_(false) {
- render_view->GetWebView()->addTextFieldDecoratorClient(this);
+ render_view_->GetWebView()->addTextFieldDecoratorClient(this);
}
PasswordGenerationManager::~PasswordGenerationManager() {}
@@ -190,6 +191,9 @@ void PasswordGenerationManager::OnPasswordAccepted(const string16& password) {
it->setValue(password);
it->setAutofilled(true);
}
+ // Advance focus to the input field next to the two password fields.
Garrett Casto 2012/06/28 21:27:13 This isn't guaranteed to be 2 password fields in t
zysxqn 2012/06/28 22:57:16 Done.
+ render_view_->GetWebView()->advanceFocus(false);
+ render_view_->GetWebView()->advanceFocus(false);
}
void PasswordGenerationManager::OnPasswordGenerationEnabled(bool enabled) {
« no previous file with comments | « chrome/renderer/autofill/password_generation_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698