Focus should be moved to the next input field after we generate the password.

chrome/renderer/autofill/password_generation_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/password_generation_manager.h"
 
 #include "base/logging.h"
 #include "chrome/common/autofill_messages.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
@@ skipping 38 matching lines @@
     return true;
 
   return false;
 }
 
 } // namespace
 
 PasswordGenerationManager::PasswordGenerationManager(
     content::RenderView* render_view)
     : content::RenderViewObserver(render_view),
+      render_view_(render_view),
       enabled_(false) {
-  render_view->GetWebView()->addTextFieldDecoratorClient(this);
+  render_view_->GetWebView()->addTextFieldDecoratorClient(this);
 }
 PasswordGenerationManager::~PasswordGenerationManager() {}
 
 void PasswordGenerationManager::DidFinishDocumentLoad(WebKit::WebFrame* frame) {
   // In every navigation, the IPC message sent by the password autofill manager
   // to query whether the current form is blacklisted or not happens when the
   // document load finishes, so we need to clear previous states here before we
   // hear back from the browser. Note that we assume there is only one account
   // creation form, but there could be multiple password forms in each frame.
   not_blacklisted_password_form_origins_.clear();
@@ skipping 112 matching lines @@
   not_blacklisted_password_form_origins_.push_back(form.origin);
   MaybeShowIcon();
 }
 
 void PasswordGenerationManager::OnPasswordAccepted(const string16& password) {
   for (std::vector<WebKit::WebInputElement>::iterator it = passwords_.begin();
        it != passwords_.end(); ++it) {
     it->setValue(password);
     it->setAutofilled(true);
   }
+  // Advance focus to the input field next to the two password fields.

[Garrett Casto, 2012/06/28 21:27:13]

This isn't guaranteed to be 2 password fields in the feature. Can you just put
this in the above loop so that this gets called the correct number of times when
we start changing the heuristics.

Also, we may want to note that this assumes that the passwords fields are
adjacent. I haven't seen a case where this isn't true yet, so it's probably a
reasonable assumption.

[zysxqn, 2012/06/28 22:57:16]

Done.

+  render_view_->GetWebView()->advanceFocus(false);
+  render_view_->GetWebView()->advanceFocus(false);
 }
 
 void PasswordGenerationManager::OnPasswordGenerationEnabled(bool enabled) {
   enabled_ = enabled;
 }
 
 void PasswordGenerationManager::MaybeShowIcon() {
   // We should show the password generation icon only when we have detected
   // account creation form and we have confirmed from browser that this form
   // is not blacklisted by the users.
   if (!account_creation_form_origin_.is_valid() ||
       passwords_.empty() ||
       not_blacklisted_password_form_origins_.empty()) {
     return;
   }
 
   for (std::vector<GURL>::iterator it =
            not_blacklisted_password_form_origins_.begin();
        it != not_blacklisted_password_form_origins_.end(); ++it) {
     if (*it == account_creation_form_origin_) {
       passwords_[0].decorationElementFor(this).setAttribute("style",
                                                             "display:block");
       return;
     }
   }
 }
 
 }  // namespace autofill