Add disk_cache watchlist, and join it.

Add disk_cache watchlist, and join it.

R=nirmimesh@chromium.org
BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146235

[gavinp, 2012-07-11 22:19:49]

Nirnimesh, WDYT?

[Nirnimesh, 2012-07-11 22:24:56]

LGTM

http://codereview.chromium.org/10704170/diff/1/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/10704170/diff/1/WATCHLISTS#newcode102
WATCHLISTS:102: 'filepath': 'net/disk_cache/|http_cache'
end with ',' to be consistent

[gavinp, 2012-07-11 22:29:21]

thanks!

http://codereview.chromium.org/10704170/diff/1/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/10704170/diff/1/WATCHLISTS#newcode102
WATCHLISTS:102: 'filepath': 'net/disk_cache/|http_cache'
On 2012/07/11 22:24:56, Nirnimesh wrote:
> end with ',' to be consistent

Done.

[commit-bot: I haz the power, 2012-07-11 22:29:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/10704170/3002

[commit-bot: I haz the power, 2012-07-11 23:29:42]

Change committed as 146235

[wtc, 2012-07-12 22:58:15]

http://codereview.chromium.org/10704170/diff/3002/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/10704170/diff/3002/WATCHLISTS#newcode102
WATCHLISTS:102: 'filepath': 'net/disk_cache/|http_cache',

The filepath seems wrong.  It seems that it should be
    'filepath': 'net/disk_cache/|net/http_cache',
or even
    'filepath': 'net/disk_cache/.*|'\
                'net/http_cache/.*',

Also, there is no 'http_cache' subdirectory under 'net'.

[gavinp, 2012-07-13 12:13:27]

On 2012/07/12 22:58:15, wtc wrote:
> http://codereview.chromium.org/10704170/diff/3002/WATCHLISTS
> File WATCHLISTS (right):
> 
> http://codereview.chromium.org/10704170/diff/3002/WATCHLISTS#newcode102
> WATCHLISTS:102: 'filepath': 'net/disk_cache/|http_cache',
> 
> The filepath seems wrong.  It seems that it should be
>     'filepath': 'net/disk_cache/|net/http_cache',
> or even
>     'filepath': 'net/disk_cache/.*|'\
>                 'net/http_cache/.*',
> 
> Also, there is no 'http_cache' subdirectory under 'net'.

I'm aware there's no such directory.

Here is what the new watchlist caches:

$ git ls-tree -r --name-only HEAD | egrep 'net/disk_cache|http_cache'
chrome/browser/resources/net_internals/http_cache_view.html
chrome/browser/resources/net_internals/http_cache_view.js
content/browser/net/view_http_cache_job_factory.cc
content/browser/net/view_http_cache_job_factory.h
net/disk_cache/addr.cc
net/disk_cache/addr.h
net/disk_cache/addr_unittest.cc
net/disk_cache/backend_impl.cc
net/disk_cache/backend_impl.h
net/disk_cache/backend_unittest.cc
net/disk_cache/bitmap.cc
net/disk_cache/bitmap.h
net/disk_cache/bitmap_unittest.cc
net/disk_cache/block_files.cc
net/disk_cache/block_files.h
net/disk_cache/block_files_unittest.cc
net/disk_cache/cache_util.h
net/disk_cache/cache_util_posix.cc
net/disk_cache/cache_util_unittest.cc
net/disk_cache/cache_util_win.cc
net/disk_cache/disk_cache.h
net/disk_cache/disk_cache_perftest.cc
net/disk_cache/disk_cache_test_base.cc
net/disk_cache/disk_cache_test_base.h
net/disk_cache/disk_cache_test_util.cc
net/disk_cache/disk_cache_test_util.h
net/disk_cache/disk_format.cc
net/disk_cache/disk_format.h
net/disk_cache/entry_impl.cc
net/disk_cache/entry_impl.h
net/disk_cache/entry_unittest.cc
net/disk_cache/errors.h
net/disk_cache/eviction.cc
net/disk_cache/eviction.h
net/disk_cache/experiments.h
net/disk_cache/file.cc
net/disk_cache/file.h
net/disk_cache/file_block.h
net/disk_cache/file_lock.cc
net/disk_cache/file_lock.h
net/disk_cache/file_posix.cc
net/disk_cache/file_win.cc
net/disk_cache/hash.cc
net/disk_cache/hash.h
net/disk_cache/histogram_macros.h
net/disk_cache/in_flight_backend_io.cc
net/disk_cache/in_flight_backend_io.h
net/disk_cache/in_flight_io.cc
net/disk_cache/in_flight_io.h
net/disk_cache/mapped_file.h
net/disk_cache/mapped_file_avoid_mmap_posix.cc
net/disk_cache/mapped_file_posix.cc
net/disk_cache/mapped_file_unittest.cc
net/disk_cache/mapped_file_win.cc
net/disk_cache/mem_backend_impl.cc
net/disk_cache/mem_backend_impl.h
net/disk_cache/mem_entry_impl.cc
net/disk_cache/mem_entry_impl.h
net/disk_cache/mem_rankings.cc
net/disk_cache/mem_rankings.h
net/disk_cache/net_log_parameters.cc
net/disk_cache/net_log_parameters.h
net/disk_cache/rankings.cc
net/disk_cache/rankings.h
net/disk_cache/sparse_control.cc
net/disk_cache/sparse_control.h
net/disk_cache/stats.cc
net/disk_cache/stats.h
net/disk_cache/stats_histogram.cc
net/disk_cache/stats_histogram.h
net/disk_cache/storage_block-inl.h
net/disk_cache/storage_block.h
net/disk_cache/storage_block_unittest.cc
net/disk_cache/stress_cache.cc
net/disk_cache/stress_support.h
net/disk_cache/trace.cc
net/disk_cache/trace.h
net/http/http_cache.cc
net/http/http_cache.h
net/http/http_cache_transaction.cc
net/http/http_cache_transaction.h
net/http/http_cache_unittest.cc
net/http/mock_http_cache.cc
net/http/mock_http_cache.h

And that list seemed exactly what I wanted to see. I know it works exactly like
I want it to. What files do you think I should remove, or add to that list?

Here's some more testing, observe that:

$ for file in `git ls-tree -r --name-only HEAD | egrep
'net/disk_cache/|http_cache'`; do python ../depot_tools/watchlists.py $file;
done | grep -v gavinp

and

$ for file in `git ls-tree -r --name-only HEAD | egrep -v
'net/disk_cache/|http_cache'`; do python ../depot_tools/watchlists.py $file;
done | grep gavinp.disk

Have no output.

I agree that this file has confusing documentation, and bad prior use. See
http://codereview.chromium.org/10698159/ for my small part in helping make this
file make more sense.

[wtc, 2012-07-13 19:44:25]

On 2012/07/13 12:13:27, gavinp wrote:
>
> Here is what the new watchlist caches:
> 
> $ git ls-tree -r --name-only HEAD | egrep 'net/disk_cache|http_cache'
[...]
> 
> And that list seemed exactly what I wanted to see. I know it works exactly
like
> I want it to. What files do you think I should remove, or add to that list?

This list is good.  I am not familiar with the syntax of 'filepath'
for watchlists.  Sorry about my confusion.