Download filename determination refactor (3/3)

chrome/browser/browsing_data_remover.cc

Index: chrome/browser/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc
index 118520296663f6e7f4aa7d18894bb64ef6e47504..9eb8e07509dc1d4d3df811ec08b427f50b5e19b0 100644
--- a/chrome/browser/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data_remover.cc
@@ -17,6 +17,7 @@
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browsing_data_helper.h"
+#include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ -294,7 +295,12 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
     DownloadManager* download_manager =
         BrowserContext::GetDownloadManager(profile_);
     download_manager->RemoveDownloadsBetween(delete_begin_, delete_end_);
-    download_manager->ClearLastDownloadPath();
+    DownloadService* download_service =
+        DownloadServiceFactory::GetForProfile(profile_);
+    ChromeDownloadManagerDelegate* download_manager_delegate =
+        static_cast<ChromeDownloadManagerDelegate*>(
+            download_service->GetDownloadManagerDelegate());

[asanka, 2012/07/11 20:03:32]

Changing DownloadService::GetDownloadManagerDelegate() to return a CDMD means
that profile_impl and off_the_record_profile_impl (and a couple of other places)
would need to know about CDMD.

[Randy Smith (Not in Mondays), 2012/07/12 17:01:22]

[Sorry, didn't see this in responding to your first comment.  ]

I think that's better than a static cast?

[asanka, 2012/07/18 21:50:56]

Done.

+    download_manager_delegate->ClearLastDownloadPath();
   }
 
   if (remove_mask & REMOVE_COOKIES) {