Download filename determination refactor (3/3)

chrome/browser/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/platform_file.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browsing_data_helper.h"
+#include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/nacl_host/nacl_browser.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/password_manager/password_store.h"
@@ skipping 257 matching lines @@
         session_service->DeleteLastSession();
 #endif
     }
   }
 
   if (remove_mask & REMOVE_DOWNLOADS) {
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Downloads"));
     DownloadManager* download_manager =
         BrowserContext::GetDownloadManager(profile_);
     download_manager->RemoveDownloadsBetween(delete_begin_, delete_end_);
-    download_manager->ClearLastDownloadPath();
+    DownloadService* download_service =
+        DownloadServiceFactory::GetForProfile(profile_);
+    ChromeDownloadManagerDelegate* download_manager_delegate =
+        static_cast<ChromeDownloadManagerDelegate*>(
+            download_service->GetDownloadManagerDelegate());

[asanka, 2012/07/11 20:03:32]

Changing DownloadService::GetDownloadManagerDelegate() to return a CDMD means
that profile_impl and off_the_record_profile_impl (and a couple of other places)
would need to know about CDMD.

[Randy Smith (Not in Mondays), 2012/07/12 17:01:22]

[Sorry, didn't see this in responding to your first comment.  ]

I think that's better than a static cast?

[asanka, 2012/07/18 21:50:56]

Done.

+    download_manager_delegate->ClearLastDownloadPath();
   }
 
   if (remove_mask & REMOVE_COOKIES) {
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Cookies"));
     // Since we are running on the UI thread don't call GetURLRequestContext().
     net::URLRequestContextGetter* rq_context = profile_->GetRequestContext();
     if (rq_context) {
       ++waiting_for_clear_cookies_count_;
       BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
@@ skipping 555 matching lines @@
       BrowserThread::UI, FROM_HERE,
       base::Bind(&BrowsingDataRemover::OnClearedServerBoundCerts,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedServerBoundCerts() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_server_bound_certs_ = false;
   NotifyAndDeleteIfDone();
 }