Download filename determination refactor (3/3)

content/public/browser/download_manager.h

Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index 4d854e201c842d7a6f2bd136a127393b9b1f9f7c..429805d554797860727d9f88b32451e9f9ced8c4 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -88,12 +88,6 @@ class CONTENT_EXPORT DownloadManager
     // from calling back to a stale pointer.
     virtual void ManagerGoingDown(DownloadManager* manager) {}
 
-    // Called immediately after the DownloadManager puts up a select file
-    // dialog.
-    // |id| indicates which download opened the dialog.
-    virtual void SelectFileDialogDisplayed(
-        DownloadManager* manager, int32 id) {}

[Randy Smith (Not in Mondays), 2012/07/10 18:33:09]

The DownloadTestObserver overrides this still.  Not sure why that didn't provoke
a compile error.

[asanka, 2012/07/11 20:03:32]

Yeah. I haven't reworked the tests yet.

-
    protected:
     virtual ~Observer() {}
   };
@@ -196,8 +190,6 @@ class CONTENT_EXPORT DownloadManager
 
   virtual BrowserContext* GetBrowserContext() const = 0;
 
-  virtual FilePath LastDownloadPath() = 0;
-
   // Creates the download item.  Must be called on the UI thread.
   // Returns the |BoundNetLog| used by the |DownloadItem|.
   virtual net::BoundNetLog CreateDownloadItem(DownloadCreateInfo* info) = 0;
@@ -212,16 +204,9 @@ class CONTENT_EXPORT DownloadManager
       const std::string& mime_type,
       DownloadItem::Observer* observer) = 0;
 
-  // Clears the last download path, used to initialize "save as" dialogs.
-  virtual void ClearLastDownloadPath() = 0;
-
-  // Called by the delegate after the save as dialog is closed.
-  virtual void FileSelected(const FilePath& path, int32 download_id) = 0;
-  virtual void FileSelectionCanceled(int32 download_id) = 0;
-
-  // Called by the delegate if it delayed the download in
-  // DownloadManagerDelegate::ShouldStartDownload and now is ready.
-  virtual void RestartDownload(int32 download_id) = 0;
+  // Clears transient state. Invoked when the user wants to clear history
+  // including transient state.
+  virtual void ClearTransientState() = 0;
 
   // Checks whether downloaded files still exist. Updates state of downloads
   // that refer to removed files. The check runs in the background and may