Download filename determination refactor (3/3)

content/public/browser/download_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active browser context in Chrome.
 //
 // Download observers:
@@ skipping 70 matching lines @@
   class CONTENT_EXPORT Observer {
    public:
     // New or deleted download, observers should query us for the current set
     // of downloads.
     virtual void ModelChanged(DownloadManager* manager) = 0;
 
     // Called when the DownloadManager is being destroyed to prevent Observers
     // from calling back to a stale pointer.
     virtual void ManagerGoingDown(DownloadManager* manager) {}
 
-    // Called immediately after the DownloadManager puts up a select file
-    // dialog.
-    // |id| indicates which download opened the dialog.
-    virtual void SelectFileDialogDisplayed(
-        DownloadManager* manager, int32 id) {}

[Randy Smith (Not in Mondays), 2012/07/10 18:33:09]

The DownloadTestObserver overrides this still.  Not sure why that didn't provoke
a compile error.

[asanka, 2012/07/11 20:03:32]

Yeah. I haven't reworked the tests yet.

-
    protected:
     virtual ~Observer() {}
   };
 
   typedef std::vector<DownloadItem*> DownloadVector;
 
   // If |dir_path| is empty, appends all temporary downloads to |*result|.
   // Otherwise, appends all temporary downloads that reside in |dir_path| to
   // |*result|.
   virtual void GetTemporaryDownloads(const FilePath& dir_path,
@@ skipping 82 matching lines @@
   // Called by the embedder, in response to
   // DownloadManagerDelegate::AddItemToPersistentStore.
   virtual void OnItemAddedToPersistentStore(int32 download_id,
                                             int64 db_handle) = 0;
 
   // The number of in progress (including paused) downloads.
   virtual int InProgressCount() const = 0;
 
   virtual BrowserContext* GetBrowserContext() const = 0;
 
-  virtual FilePath LastDownloadPath() = 0;
-
   // Creates the download item.  Must be called on the UI thread.
   // Returns the |BoundNetLog| used by the |DownloadItem|.
   virtual net::BoundNetLog CreateDownloadItem(DownloadCreateInfo* info) = 0;
 
   // Creates a download item for the SavePackage system.
   // Must be called on the UI thread.  Note that the DownloadManager
   // retains ownership.
   virtual DownloadItem* CreateSavePackageDownloadItem(
       const FilePath& main_file_path,
       const GURL& page_url,
       bool is_otr,
       const std::string& mime_type,
       DownloadItem::Observer* observer) = 0;
 
-  // Clears the last download path, used to initialize "save as" dialogs.
-  virtual void ClearLastDownloadPath() = 0;
-
-  // Called by the delegate after the save as dialog is closed.
-  virtual void FileSelected(const FilePath& path, int32 download_id) = 0;
-  virtual void FileSelectionCanceled(int32 download_id) = 0;
-
-  // Called by the delegate if it delayed the download in
-  // DownloadManagerDelegate::ShouldStartDownload and now is ready.
-  virtual void RestartDownload(int32 download_id) = 0;
+  // Clears transient state. Invoked when the user wants to clear history
+  // including transient state.
+  virtual void ClearTransientState() = 0;
 
   // Checks whether downloaded files still exist. Updates state of downloads
   // that refer to removed files. The check runs in the background and may
   // finish asynchronously after this method returns.
   virtual void CheckForHistoryFilesRemoval() = 0;
 
   // Get the download item from the history map.  Useful after the item has
   // been removed from the active map, or was retrieved from the history DB.
   virtual DownloadItem* GetDownloadItem(int id) = 0;
 
@@ skipping 13 matching lines @@
  protected:
   virtual ~DownloadManager() {}
 
  private:
   friend class base::RefCountedThreadSafe<DownloadManager>;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_