Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.cc
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc
index bcb59bece24a1aa9256fad00cfd074a03021f624..6bf52e94415e06f7e0964ee415ad1dafc2497b4c 100644
--- a/chrome/browser/ui/views/download/download_item_view.cc
+++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -297,9 +297,6 @@ void DownloadItemView::OnDownloadUpdated(DownloadItem* download) {
StopDownloadProgress();
LoadIcon();
break;
- case DownloadItem::REMOVING:
- parent_->RemoveDownloadView(this); // This will delete us!
- return;
default:
NOTREACHED();
}
@@ -320,6 +317,10 @@ void DownloadItemView::OnDownloadUpdated(DownloadItem* download) {
parent()->SchedulePaint();
}
+void DownloadItemView::OnDownloadDestructed(DownloadItem* download) {
+ parent_->RemoveDownloadView(this); // This will delete us!
+}
+
void DownloadItemView::OnDownloadOpened(DownloadItem* download) {
disabled_while_opening_ = true;
SetEnabled(false);

Powered by Google App Engine
This is Rietveld 408576698