chrome/browser/download/download_item_model.cc - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_model.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_download_observer.cc ('k') | chrome/browser/download/download_test_observer.h » ('j') | content/browser/download/download_item_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_item_model.cc

diff --git a/chrome/browser/download/download_item_model.cc b/chrome/browser/download/download_item_model.cc

index b6363775ab1f41b46f47ab7ecd5589bed400328d..b7912e967c8769a44199755522eb9e0fe0ed4ef8 100644

--- a/chrome/browser/download/download_item_model.cc

+++ b/chrome/browser/download/download_item_model.cc

@@ -128,8 +128,6 @@ string16 DownloadItemModel::GetStatusText() {

case DownloadItem::CANCELLED:

status_text = l10n_util::GetStringUTF16(IDS_DOWNLOAD_STATUS_CANCELLED);

break;

- case DownloadItem::REMOVING:

Randy Smith (Not in Mondays) 2012/06/29 19:34:54 Asanka, what protection is there in DownloadItemMo

asanka 2012/07/11 18:12:19 DownloadItemModel doesn't observe DownloadItems. I

- break;

case DownloadItem::INTERRUPTED:

reason = download_->GetLastReason();

status_text = InterruptReasonStatusMessage(reason);