chrome/browser/download/download_test_observer.h - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_test_observer.h

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_item_model.cc ('K') | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/download/download_test_observer.cc » ('j') | content/browser/download/download_item_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_test_observer.h

diff --git a/chrome/browser/download/download_test_observer.h b/chrome/browser/download/download_test_observer.h

index d8ea6850689aa20edba9c6bbbd2cc2789553ce0e..b0fd0a859a633c0ab369a46fb96ad30e8077f415 100644

--- a/chrome/browser/download/download_test_observer.h

+++ b/chrome/browser/download/download_test_observer.h

@@ -62,7 +62,7 @@ class DownloadTestObserver : public content::DownloadManager::Observer,

// content::DownloadItem::Observer

virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;

- virtual void OnDownloadOpened(content::DownloadItem* download) OVERRIDE {}

+ virtual void OnDownloadDestructed(content::DownloadItem* download) OVERRIDE;

// content::DownloadManager::Observer

virtual void ModelChanged(content::DownloadManager* manager) OVERRIDE;

@@ -216,7 +216,7 @@ class DownloadTestFlushObserver

// DownloadItem observer methods.

virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;

- virtual void OnDownloadOpened(content::DownloadItem* download) OVERRIDE {}

+ virtual void OnDownloadDestructed(content::DownloadItem* download) OVERRIDE;

protected:

friend class base::RefCountedThreadSafe<DownloadTestFlushObserver>;