Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

chrome/browser/automation/automation_provider.cc

Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index f4d6d70139eb90d1cd399c5779ab26b1255bd4f9..21c9de243a67efbe1f5f81084cb4c656e4dadbdf 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -304,7 +304,6 @@ DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
   std::map<DownloadItem::DownloadState, std::string> state_to_string;
   state_to_string[DownloadItem::IN_PROGRESS] = std::string("IN_PROGRESS");
   state_to_string[DownloadItem::CANCELLED] = std::string("CANCELLED");
-  state_to_string[DownloadItem::REMOVING] = std::string("REMOVING");

[Randy Smith (Not in Mondays), 2012/07/11 17:55:37]

Can you say a word or two about why you don't think the consumers (direct and
indirect) of GetDictionaryFromDownloadItem() don't need a notification about a
download going away?  (It may be completely safe, I'm just looking for
reassurance of due diligence.)

[benjhayden, 2012/07/13 20:03:17]

grep -i REMOVING $(find . -iname '*.py'|grep download)
Looks like no pyauto tests rely on the REMOVING state. They'll continue to have
access to the DownloadManager::Observer::ModelChanged event.

[Randy Smith (Not in Mondays), 2012/07/14 19:25:53]

And you're comfortable that the pyauto tests are the only AutomationProvider
customers?  (I think that's true; the other options are ui_tests and
interactive_ui_tests, which I believe don't have any download tests in them, but
it's worth checking.)

[benjhayden, 2012/07/23 15:43:09]

ui_unittests and interactive_ui_tests pass on all bots for this cl.
If there are any automation scripts that rely on REMOVING, then they'll break in
a way that can be fixed easily, and we can add comments to this file about them
so they don't get lost again.

   state_to_string[DownloadItem::INTERRUPTED] = std::string("INTERRUPTED");
   state_to_string[DownloadItem::COMPLETE] = std::string("COMPLETE");