Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

chrome/browser/automation/automation_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_provider.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 286 matching lines @@
   DCHECK(parent);
   return chrome::GetIndexOfTab(parent, controller->GetWebContents());
 }
 
 // TODO(phajdan.jr): move to TestingAutomationProvider.
 DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
     const DownloadItem* download) {
   std::map<DownloadItem::DownloadState, std::string> state_to_string;
   state_to_string[DownloadItem::IN_PROGRESS] = std::string("IN_PROGRESS");
   state_to_string[DownloadItem::CANCELLED] = std::string("CANCELLED");
-  state_to_string[DownloadItem::REMOVING] = std::string("REMOVING");

[Randy Smith (Not in Mondays), 2012/07/11 17:55:37]

Can you say a word or two about why you don't think the consumers (direct and
indirect) of GetDictionaryFromDownloadItem() don't need a notification about a
download going away?  (It may be completely safe, I'm just looking for
reassurance of due diligence.)

[benjhayden, 2012/07/13 20:03:17]

grep -i REMOVING $(find . -iname '*.py'|grep download)
Looks like no pyauto tests rely on the REMOVING state. They'll continue to have
access to the DownloadManager::Observer::ModelChanged event.

[Randy Smith (Not in Mondays), 2012/07/14 19:25:53]

And you're comfortable that the pyauto tests are the only AutomationProvider
customers?  (I think that's true; the other options are ui_tests and
interactive_ui_tests, which I believe don't have any download tests in them, but
it's worth checking.)

[benjhayden, 2012/07/23 15:43:09]

ui_unittests and interactive_ui_tests pass on all bots for this cl.
If there are any automation scripts that rely on REMOVING, then they'll break in
a way that can be fixed easily, and we can add comments to this file about them
so they don't get lost again.

   state_to_string[DownloadItem::INTERRUPTED] = std::string("INTERRUPTED");
   state_to_string[DownloadItem::COMPLETE] = std::string("COMPLETE");
 
   std::map<DownloadItem::SafetyState, std::string> safety_state_to_string;
   safety_state_to_string[DownloadItem::SAFE] = std::string("SAFE");
   safety_state_to_string[DownloadItem::DANGEROUS] = std::string("DANGEROUS");
   safety_state_to_string[DownloadItem::DANGEROUS_BUT_VALIDATED] =
       std::string("DANGEROUS_BUT_VALIDATED");
 
   DictionaryValue* dl_item_value = new DictionaryValue;
@@ skipping 432 matching lines @@
 
   return NULL;
 }
 
 void AutomationProvider::SaveAsAsync(int tab_handle) {
   NavigationController* tab = NULL;
   WebContents* web_contents = GetWebContentsForHandle(tab_handle, &tab);
   if (web_contents)
     web_contents->OnSavePage();
 }