Issue 10703096: [IO] Improve documentation for dart:io Socket.onWrite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703096: [IO] Improve documentation for dart:io Socket.onWrite. (Closed)

Created:
8 years, 5 months ago by Bill Hesse

Modified:
8 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[IO] Improve documentation for dart:io Socket.onWrite. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9428

Patch Set 2 : address comment #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/bin/socket.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/10703096/diff/1/runtime/bin/socket.dart File runtime/bin/socket.dart (right): http://codereview.chromium.org/10703096/diff/1/runtime/bin/socket.dart#newcode78 runtime/bin/socket.dart:78: * writing. Then the handler is reset to ...

8 years, 5 months ago (2012-07-06 04:02:11 UTC) #2

Bill Hesse

8 years, 5 months ago (2012-07-06 08:41:24 UTC) #3

http://codereview.chromium.org/10703096/diff/1/runtime/bin/socket.dart
File runtime/bin/socket.dart (right):

http://codereview.chromium.org/10703096/diff/1/runtime/bin/socket.dart#newcode78
runtime/bin/socket.dart:78: * writing. Then the handler is reset to null. This
handler is used when
On 2012/07/06 04:02:11, Søren Gjesse wrote:
> is reset -> is automatically reset

Done.

Expand Messages | Collapse Messages

Issue 10703096: [IO] Improve documentation for dart:io Socket.onWrite. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comment #

Messages