Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9105)

Unified Diff: chrome/common/extensions/extension.cc

Issue 10703090: Turn pageAction.show -> browserAction.sensibleThing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: views (incomplete) Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index abb94debfcd4bde74c5cbd4fe48839709aa8e91d..a29e29d653ac8653ba76507681683d4da6e8b2c9 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -812,9 +812,12 @@ scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(
string16* error) {
scoped_ptr<ExtensionAction> result(new ExtensionAction(id(), action_type));
- // Page actions are hidden by default, and browser actions ignore
- // visibility.
- result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
+ // Page actions are hidden/disabled by default, and browser actions are
+ // visible/enabled by default.
+ if (action_type == ExtensionAction::TYPE_PAGE)
+ result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
+ else
+ result->SetIsVisible(ExtensionAction::kDefaultTabId, true);
if (manifest_version_ == 1) {
ListValue* icons = NULL;
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698