Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5477)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 10703027: Workaround Skia clipping bug in print_web_view_helper.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.cc
===================================================================
--- chrome/renderer/print_web_view_helper.cc (revision 144719)
+++ chrome/renderer/print_web_view_helper.cc (working copy)
@@ -428,6 +428,9 @@
// TODO(arthurhsu): Following code works on Windows only so far.
// See crbug.com/108599 and its blockers for more information.
scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText());
+ // TODO(asvitkine): The below line is to workaround http://crbug.com/133548.
+ // Remove it when the underlying Skia bug has been fixed.
vandebo (ex-Chrome) 2012/06/28 18:07:27 nit: "Remove" should align with "TODO"
Alexei Svitkine (slow) 2012/06/28 18:29:19 Done.
+ render_text->set_clip_to_display_rect(false);
render_text->SetText(text);
int font_size = printing::kSettingHeaderFooterFontSize / webkit_scale_factor;
render_text->SetFontSize(font_size);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698