Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/renderer/print_web_view_helper.cc

Issue 10703027: Workaround Skia clipping bug in print_web_view_helper.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/print_web_view_helper.h" 5 #include "chrome/renderer/print_web_view_helper.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 WebKit::WebCanvas* canvas, 421 WebKit::WebCanvas* canvas,
422 HeaderFooterPaint paint, 422 HeaderFooterPaint paint,
423 float webkit_scale_factor, 423 float webkit_scale_factor,
424 const PageSizeMargins& page_layout, 424 const PageSizeMargins& page_layout,
425 printing::HorizontalHeaderFooterPosition horizontal_position, 425 printing::HorizontalHeaderFooterPosition horizontal_position,
426 printing::VerticalHeaderFooterPosition vertical_position, 426 printing::VerticalHeaderFooterPosition vertical_position,
427 double offset_to_baseline) { 427 double offset_to_baseline) {
428 // TODO(arthurhsu): Following code works on Windows only so far. 428 // TODO(arthurhsu): Following code works on Windows only so far.
429 // See crbug.com/108599 and its blockers for more information. 429 // See crbug.com/108599 and its blockers for more information.
430 scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText()); 430 scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText());
431 // TODO(asvitkine): The below line is to workaround http://crbug.com/133548.
432 // Remove it when the underlying Skia bug has been fixed.
vandebo (ex-Chrome) 2012/06/28 18:07:27 nit: "Remove" should align with "TODO"
Alexei Svitkine (slow) 2012/06/28 18:29:19 Done.
433 render_text->set_clip_to_display_rect(false);
431 render_text->SetText(text); 434 render_text->SetText(text);
432 int font_size = printing::kSettingHeaderFooterFontSize / webkit_scale_factor; 435 int font_size = printing::kSettingHeaderFooterFontSize / webkit_scale_factor;
433 render_text->SetFontSize(font_size); 436 render_text->SetFontSize(font_size);
434 gfx::Size text_size = render_text->GetStringSize(); 437 gfx::Size text_size = render_text->GetStringSize();
435 // Text height includes the configured gap between header/footer and the 438 // Text height includes the configured gap between header/footer and the
436 // context, plus the 1 point that we later substracted for ensuring the 439 // context, plus the 1 point that we later substracted for ensuring the
437 // overlapping between RenderText rect and the content area. 440 // overlapping between RenderText rect and the content area.
438 int text_height = text_size.height() + 1 + 441 int text_height = text_size.height() + 1 +
439 printing::kSettingHeaderFooterInterstice; 442 printing::kSettingHeaderFooterInterstice;
440 SkScalar margin_left = page_layout.margin_left / webkit_scale_factor; 443 SkScalar margin_left = page_layout.margin_left / webkit_scale_factor;
(...skipping 1431 matching lines...) Expand 10 before | Expand all | Expand 10 after
1872 DCHECK(IsRendering()); 1875 DCHECK(IsRendering());
1873 return prep_frame_view_->GetPrintCanvasSize(); 1876 return prep_frame_view_->GetPrintCanvasSize();
1874 } 1877 }
1875 1878
1876 void PrintWebViewHelper::PrintPreviewContext::ClearContext() { 1879 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
1877 prep_frame_view_.reset(); 1880 prep_frame_view_.reset();
1878 metafile_.reset(); 1881 metafile_.reset();
1879 pages_to_render_.clear(); 1882 pages_to_render_.clear();
1880 error_ = PREVIEW_ERROR_NONE; 1883 error_ = PREVIEW_ERROR_NONE;
1881 } 1884 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698