gdata: Fix a bug in GDataLevelDB where errors are not handled right

chrome/browser/chromeos/gdata/gdata_db.h

Index: chrome/browser/chromeos/gdata/gdata_db.h
diff --git a/chrome/browser/chromeos/gdata/gdata_db.h b/chrome/browser/chromeos/gdata/gdata_db.h
index 67d1e58115fae00a0f9fa8d881dee72949560e80..e35bd32d035a3c040df30d407590ce195484efef 100644
--- a/chrome/browser/chromeos/gdata/gdata_db.h
+++ b/chrome/browser/chromeos/gdata/gdata_db.h
@@ -12,6 +12,12 @@
 
 class FilePath;
 
+namespace google {
+namespace protobuf {
+class MessageLite;
+}  // namespace protobuf
+}  // namespace google
+
 namespace gdata {
 
 class GDataEntry;
@@ -47,6 +53,12 @@ class GDataDB {
   // Will not return NULL.
   virtual scoped_ptr<GDataDBIter> CreateIterator(const FilePath& path) = 0;
 
+  // Puts raw |protobuf| keyed with |resource_id| to the database.
+  // Used for testing (ex. injecting incompatibe proto).
+  virtual Status PutRawForTesting(
+      const std::string& resource_id,
+      const google::protobuf::MessageLite& protobuf) = 0;

[achuithb, 2012/07/10 17:21:19]

Any reason why we don't just pass in a string as the value to store in the db?
The protobuf is invalid anyway. It'll make the signature nicer and you don't
have to forward declare google::protobuf::MessageLite.

[satorux1, 2012/07/10 17:28:35]

Good idea. Done.

+
  protected:
   GDataDB() {}
 };