gdata: Fix a bug in GDataLevelDB where errors are not handled right

chrome/browser/chromeos/gdata/gdata_db.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DB_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DB_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 
 class FilePath;
 
+namespace google {
+namespace protobuf {
+class MessageLite;
+}  // namespace protobuf
+}  // namespace google
+
 namespace gdata {
 
 class GDataEntry;
 class GDataDBIter;
 
 // GData Database interface class.
 class GDataDB {
  public:
   enum Status {
     DB_OK = 0,
@@ skipping 15 matching lines @@
   // Fetches a GDataEntry* by key |resource_id| or |path| respectively.
   virtual Status GetByResourceId(const std::string& resource_id,
                                  scoped_ptr<GDataEntry>* entry) = 0;
   virtual Status GetByPath(const FilePath& path,
                            scoped_ptr<GDataEntry>* entry) = 0;
 
   // Creates an iterator to fetch all GDataEntry's under |path|.
   // Will not return NULL.
   virtual scoped_ptr<GDataDBIter> CreateIterator(const FilePath& path) = 0;
 
+  // Puts raw |protobuf| keyed with |resource_id| to the database.
+  // Used for testing (ex. injecting incompatibe proto).
+  virtual Status PutRawForTesting(
+      const std::string& resource_id,
+      const google::protobuf::MessageLite& protobuf) = 0;

[achuithb, 2012/07/10 17:21:19]

Any reason why we don't just pass in a string as the value to store in the db?
The protobuf is invalid anyway. It'll make the signature nicer and you don't
have to forward declare google::protobuf::MessageLite.

[satorux1, 2012/07/10 17:28:35]

Good idea. Done.

+
  protected:
   GDataDB() {}
 };
 
 // GData Database Iterator interface class.
 class GDataDBIter {
  public:
   virtual ~GDataDBIter() {}
 
   // Fetches the next |entry| in the iteration sequence. Returns false when
   // there are no more entries.
   virtual bool GetNext(std::string* path, scoped_ptr<GDataEntry>* entry) = 0;
 
  protected:
   GDataDBIter() {}
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DB_H_