Log a new histogram to track calls to FirstPotentialDefaultEngine.

Log a new histogram to track calls to FirstPotentialDefaultEngine.

We use this to help spot spikes in calls to reset the DSP.

BUG=132446
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145733

[SteveT, 2012-07-05 15:02:34]

Hey Nick,

As discussed, here is a patch to add a new histogram to count the number of
calls to FirstPotentialDefaultEngine. It's a shame that it's actually mostly
called from inside FindNewDefaultSearchProvider, since we'll lose some
information about the source of the call.

We could track calls to that instead, but then it's unclear if
FirstPotentialDefaultEngine is actually called, or if we managed to fetch the
DSP from the prepop data
(http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/search_engin...).

[Nicolas Zea, 2012-07-09 17:57:41]

http://codereview.chromium.org/10701103/diff/1/chrome/browser/search_engines/...
File chrome/browser/search_engines/template_url_service.cc (right):

http://codereview.chromium.org/10701103/diff/1/chrome/browser/search_engines/...
chrome/browser/search_engines/template_url_service.cc:614: if
(sync_processor_.get()) {
perhaps check processing_sync_changes_ instead? That way we know that it's the
result of a sync change, instead of whether this client is simply syncing but
something else happened?

[SteveT, 2012-07-09 18:13:38]

Thanks for catching that error. Over to you.

http://codereview.chromium.org/10701103/diff/1/chrome/browser/search_engines/...
File chrome/browser/search_engines/template_url_service.cc (right):

http://codereview.chromium.org/10701103/diff/1/chrome/browser/search_engines/...
chrome/browser/search_engines/template_url_service.cc:614: if
(sync_processor_.get()) {
Ah, yeah, that's the correct thing to do. Done.

[Nicolas Zea, 2012-07-09 18:16:01]

LGTM

[commit-bot: I haz the power, 2012-07-09 18:19:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10701103/5001

[commit-bot: I haz the power, 2012-07-09 20:06:51]

Change committed as 145733