Log a new histogram to track calls to FirstPotentialDefaultEngine.

chrome/browser/search_engines/template_url_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search_engines/template_url_service.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/guid.h"
@@ skipping 68 matching lines @@
       url1->HasSameKeywordAs(*url2) &&
       (url1->url() == url2->url()) &&
       (url1->suggestions_url() == url2->suggestions_url()) &&
       (url1->instant_url() == url2->instant_url()) &&
       (url1->favicon_url() == url2->favicon_url()) &&
       (url1->safe_for_autoreplace() == url2->safe_for_autoreplace()) &&
       (url1->show_in_default_list() == url2->show_in_default_list()) &&
       (url1->input_encodings() == url2->input_encodings());
 }
 
+const char kFirstPotentialEngineHistogramName[] =
+    "Search.FirstPotentialEngineCalled";
+
+// Values for an enumerated histogram used to track whenever
+// FirstPotentialDefaultEngine is called, and from where.
+enum FirstPotentialEngineCaller {
+  FIRST_POTENTIAL_CALLSITE_FIND_NEW_DSP,
+  FIRST_POTENTIAL_CALLSITE_FIND_NEW_DSP_SYNCING,
+  FIRST_POTENTIAL_CALLSITE_ON_LOAD,
+  FIRST_POTENTIAL_CALLSITE_MAX,
+};
+
 TemplateURL* FirstPotentialDefaultEngine(
     const TemplateURLService::TemplateURLVector& template_urls) {
   for (TemplateURLService::TemplateURLVector::const_iterator i(
        template_urls.begin()); i != template_urls.end(); ++i) {
     if ((*i)->ShowInDefaultList()) {
       DCHECK(!(*i)->IsExtensionKeyword());
       return *i;
     }
   }
   return NULL;
@@ skipping 493 matching lines @@
   // See if the prepopulated default still exists.
   scoped_ptr<TemplateURL> prepopulated_default(
       TemplateURLPrepopulateData::GetPrepopulatedDefaultSearch(profile_));
   for (TemplateURLVector::iterator i = template_urls_.begin();
        i != template_urls_.end(); ++i) {
     if ((*i)->prepopulate_id() == prepopulated_default->prepopulate_id())
       return *i;
   }
   // If not, use the first non-extension keyword of the templates that supports
   // search term replacement.
+  if (sync_processor_.get()) {

[Nicolas Zea, 2012/07/09 17:57:41]

perhaps check processing_sync_changes_ instead? That way we know that it's the
result of a sync change, instead of whether this client is simply syncing but
something else happened?

[SteveT, 2012/07/09 18:13:38]

Ah, yeah, that's the correct thing to do. Done.

+    UMA_HISTOGRAM_ENUMERATION(kFirstPotentialEngineHistogramName,
+                              FIRST_POTENTIAL_CALLSITE_FIND_NEW_DSP_SYNCING,
+                              FIRST_POTENTIAL_CALLSITE_MAX);
+  } else {
+    UMA_HISTOGRAM_ENUMERATION(kFirstPotentialEngineHistogramName,
+                              FIRST_POTENTIAL_CALLSITE_FIND_NEW_DSP,
+                              FIRST_POTENTIAL_CALLSITE_MAX);
+  }
   return FirstPotentialDefaultEngine(template_urls_);
 }
 
 void TemplateURLService::AddObserver(TemplateURLServiceObserver* observer) {
   model_observers_.AddObserver(observer);
 }
 
 void TemplateURLService::RemoveObserver(TemplateURLServiceObserver* observer) {
   model_observers_.RemoveObserver(observer);
 }
@@ skipping 102 matching lines @@
     }
   } else {
     // If we had a managed default, replace it with the synced default if
     // applicable, or the first provider of the list.
     TemplateURL* synced_default = GetPendingSyncedDefaultSearchProvider();
     if (synced_default) {
       default_search_provider = synced_default;
       pending_synced_default_search_ = false;
     } else if (database_specified_a_default &&
                default_search_provider == NULL) {
+      UMA_HISTOGRAM_ENUMERATION(kFirstPotentialEngineHistogramName,
+          FIRST_POTENTIAL_CALLSITE_ON_LOAD, FIRST_POTENTIAL_CALLSITE_MAX);
       default_search_provider = FirstPotentialDefaultEngine(template_urls);
     }
 
     // If the default search provider existed previously, then just
     // set the member variable. Otherwise, we'll set it using the method
     // to ensure that it is saved properly after its id is set.
     if (default_search_provider &&
         (default_search_provider->id() != kInvalidTemplateURLID)) {
       default_search_provider_ = default_search_provider;
       default_search_provider = NULL;
@@ skipping 1671 matching lines @@
     // TODO(mpcomplete): If we allow editing extension keywords, then those
     // should be persisted to disk and synced.
     if (template_url->sync_guid().empty() &&
         !template_url->IsExtensionKeyword()) {
       template_url->data_.sync_guid = base::GenerateGUID();
       if (service_.get())
         service_->UpdateKeyword(template_url->data());
     }
   }
 }