Introduce LaunchParams struct for opening chrome apps.

chrome/browser/ui/extensions/application_launch.h

Index: chrome/browser/ui/extensions/application_launch.h
diff --git a/chrome/browser/ui/extensions/application_launch.h b/chrome/browser/ui/extensions/application_launch.h
index bd6fb7e170f7c80adeb584f9ff36b8ff48b52e1e..7938649416e4b997f72b365f11a89b99e0654ce8 100644
--- a/chrome/browser/ui/extensions/application_launch.h
+++ b/chrome/browser/ui/extensions/application_launch.h
@@ -24,19 +24,34 @@ class Extension;
 
 namespace application_launch {
 
-// Open |extension| in |container|, using |disposition| if container type is
-// TAB. Returns the WebContents* that was created or NULL. If non-empty,
-// |override_url| is used in place of the app launch url. Pass relevant
-// information in |command_line| onto platform app as launch data.
-// |command_line| can be NULL, indicating there is no launch data to pass on.
-// TODO(benwells): Put the parameters to this into an ApplicationLaunchParams
-// struct.
-content::WebContents* OpenApplication(Profile* profile,
-                                      const extensions::Extension* extension,
-                                      extension_misc::LaunchContainer container,
-                                      const GURL& override_url,
-                                      WindowOpenDisposition disposition,
-                                      const CommandLine* command_line);
+struct LaunchParams {
+  LaunchParams(Profile* profile,
+               const extensions::Extension* extension,
+               extension_misc::LaunchContainer container,
+               WindowOpenDisposition disposition);
+
+  // The profile to load the application from.
+  Profile* profile;
+
+  // The extension to load.
+  const extensions::Extension* extension;
+
+  // The container type to launch the application in.
+  extension_misc::LaunchContainer container;
+
+  // If container is TAB, this field controls how the tab is opened.
+  WindowOpenDisposition disposition;
+
+  // If non-empty, use override_url in place of the application's launch url.
+  GURL override_url;
+
+  // If non-NULL, information from the command line may be passed on to the
+  // application.
+  const CommandLine* command_line;
+};
+
+// Open the application in a way specified by |params|.
+content::WebContents* OpenApplication(const LaunchParams& params);
 
 // Opens |url| in a new application panel window for the specified url.
 content::WebContents* OpenApplicationPanel(

[Mihai Parparita -not on Chrome, 2012/07/11 00:38:36]

Can these other methods be removed from the header file and into an anonymous
namespace in the .cc file? OpenApplicationPanel is never used outside, and it
seems like the others should end up on the LaunchParams codepath too.

[Dmitry Titov, 2012/07/11 01:03:24]

This method is removed in https://chromiumcodereview.appspot.com/10689071/
which I think already landed...

Also, the panel_app_browsertest.cc is removed. 

[benwells, 2012/07/12 04:21:02]

Yes indeed, I was thinking the same thing but forgot about it :(

I've moved OpenApplicationTab and OpenApplicationWindow (the patch Dmitry
mentions was reverted, I'm waiting for it to come in before finishing this off.