Introduce LaunchParams struct for opening chrome apps.

chrome/browser/ui/extensions/application_launch.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
 #define CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
 #pragma once
 
 #include "chrome/common/extensions/extension_constants.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class Browser;
 class CommandLine;
 class GURL;
 class Profile;
 
 namespace content {
 class WebContents;
 }
 
 namespace extensions {
 class Extension;
 }
 
 namespace application_launch {
 
-// Open |extension| in |container|, using |disposition| if container type is
-// TAB. Returns the WebContents* that was created or NULL. If non-empty,
-// |override_url| is used in place of the app launch url. Pass relevant
-// information in |command_line| onto platform app as launch data.
-// |command_line| can be NULL, indicating there is no launch data to pass on.
-// TODO(benwells): Put the parameters to this into an ApplicationLaunchParams
-// struct.
-content::WebContents* OpenApplication(Profile* profile,
-                                      const extensions::Extension* extension,
-                                      extension_misc::LaunchContainer container,
-                                      const GURL& override_url,
-                                      WindowOpenDisposition disposition,
-                                      const CommandLine* command_line);
+struct LaunchParams {
+  LaunchParams(Profile* profile,
+               const extensions::Extension* extension,
+               extension_misc::LaunchContainer container,
+               WindowOpenDisposition disposition);
+
+  // The profile to load the application from.
+  Profile* profile;
+
+  // The extension to load.
+  const extensions::Extension* extension;
+
+  // The container type to launch the application in.
+  extension_misc::LaunchContainer container;
+
+  // If container is TAB, this field controls how the tab is opened.
+  WindowOpenDisposition disposition;
+
+  // If non-empty, use override_url in place of the application's launch url.
+  GURL override_url;
+
+  // If non-NULL, information from the command line may be passed on to the
+  // application.
+  const CommandLine* command_line;
+};
+
+// Open the application in a way specified by |params|.
+content::WebContents* OpenApplication(const LaunchParams& params);
 
 // Opens |url| in a new application panel window for the specified url.
 content::WebContents* OpenApplicationPanel(

[Mihai Parparita -not on Chrome, 2012/07/11 00:38:36]

Can these other methods be removed from the header file and into an anonymous
namespace in the .cc file? OpenApplicationPanel is never used outside, and it
seems like the others should end up on the LaunchParams codepath too.

[Dmitry Titov, 2012/07/11 01:03:24]

This method is removed in https://chromiumcodereview.appspot.com/10689071/
which I think already landed...

Also, the panel_app_browsertest.cc is removed. 

[benwells, 2012/07/12 04:21:02]

Yes indeed, I was thinking the same thing but forgot about it :(

I've moved OpenApplicationTab and OpenApplicationWindow (the patch Dmitry
mentions was reverted, I'm waiting for it to come in before finishing this off.

     Profile* profile,
     const extensions::Extension* extension,
     const GURL& url);
 
 // Opens a new application window for the specified url. If |as_panel| is true,

[Mihai Parparita -not on Chrome, 2012/07/11 00:38:36]

as_panel seems to no longer exist.

 // the application will be opened as a Browser::Type::APP_PANEL in app panel
 // window, otherwise it will be opened as as either Browser::Type::APP a.k.a.
 // "thin frame" (if |extension| is NULL) or Browser::Type::EXTENSION_APP (if
 // |extension| is non-NULL)./ If |app_browser| is not NULL, it is set to the
 // browser that hosts the returned tab.
 content::WebContents* OpenApplicationWindow(
     Profile* profile,
     const extensions::Extension* extension,
     extension_misc::LaunchContainer container,
     const GURL& url,
     Browser** app_browser);
 
 // Open |url| in an app shortcut window.  If |update_shortcut| is true,
 // update the name, description, and favicon of the shortcut.
 // There are two kinds of app shortcuts: Shortcuts to a URL,
 // and shortcuts that open an installed application.  This function
 // is used to open the former.  To open the latter, use
 // Browser::OpenApplicationWindow().

[Mihai Parparita -not on Chrome, 2012/07/11 00:38:36]

OpenApplicationWindow is no longer in Browser.

[benwells, 2012/07/12 04:21:02]

Done.

 content::WebContents* OpenAppShortcutWindow(Profile* profile,
                                             const GURL& url,
                                             bool update_shortcut);
 
 // Open an application for |extension| using |disposition|.  Returns NULL if
 // there are no appropriate existing browser windows for |profile|. If
 // non-empty, |override_url| is used in place of the app launch url.
 content::WebContents* OpenApplicationTab(Profile* profile,
                                          const extensions::Extension* extension,
                                          const GURL& override_url,
                                          WindowOpenDisposition disposition);
 
 }  // namespace application_launch
 
 #endif  // CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_